From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthieu CASTET Subject: Re: [PATCH V2 2/2] mtd: msm_nand: Add initial msm nand driver support. Date: Mon, 18 Apr 2011 09:32:14 +0200 Message-ID: <4DABE8FE.5040300@parrot.com> References: <1302938249-4601-1-git-send-email-mnalajal@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1302938249-4601-1-git-send-email-mnalajal@codeaurora.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Murali Nalajala Cc: "linux-arm-msm@vger.kernel.org" , Dima Zavin , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , "linux-mtd@lists.infradead.org" , Brian Swetland , "dwmw2@infradead.org" , "linux-arm-kernel@lists.infradead.org" List-Id: linux-arm-msm@vger.kernel.org SGksCgpNdXJhbGkgTmFsYWphbGEgYSDDqWNyaXQgOgo+IEFkZCBpbml0aWFsIG1zbSBuYW5kIGRy aXZlciBzdXBwb3J0IGZvciBRdWFsY29tbSBNU00gcGxhdGZvcm1zLgo+IFRoaXMgZHJpdmVyIGlz IGNhcGFibGUgb2YgaGFuZGxpbmcgYm90aCAyayBhbmQgNGsgcGFnZSBzdXBwb3J0Cj4gbmFuZCBk ZXZpY2VzLgo+IAo+IFRoaXMgZHJpdmVyIHdhcyBvcmlnaW5hbGx5IGRldmVsb3BlZCBieSBBcnZl IEhqw7hubmV2w6VnIGF0IGdvb2dsZS4KPiBJdHMgc291cmNlIGlzIGF2YWlsYWJsZSBhdAo+IGh0 dHA6Ly9hbmRyb2lkLmdpdC5rZXJuZWwub3JnLz9wPWtlcm5lbC9tc20uZ2l0IHVuZGVyCj4gYW5k cm9pZC1tc20tMi42LjM1IGJyYW5jaC4KPiAKPiBDQzogRGltYSBaYXZpbiA8ZGltYUBhbmRyb2lk LmNvbT4KPiBDQzogQnJpYW4gU3dldGxhbmQgPHN3ZXRsYW5kQGdvb2dsZS5jb20+Cj4gQ0M6IEFy dmUgSGrDuG5uZXbDpWcgPGFydmVAYW5kcm9pZC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogTXVyYWxp IE5hbGFqYWxhIDxtbmFsYWphbEBjb2RlYXVyb3JhLm9yZz4KPiAtLS0KPiBDaGFuZ2VzIGluIFYy Cj4gKiBUdXJuIG1vc3Qgb2YgdGhlIHByX2luZm8oKSBjYWxscyBpbnRvIHByX2RlYnVnKCkuCj4g Cj4gIGRyaXZlcnMvbXRkL2RldmljZXMvS2NvbmZpZyAgICB8ICAgMTEgKwo+ICBkcml2ZXJzL210 ZC9kZXZpY2VzL01ha2VmaWxlICAgfCAgICAxICsKPiAgZHJpdmVycy9tdGQvZGV2aWNlcy9tc21f bmFuZC5jIHwgMTU5NyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4g IGRyaXZlcnMvbXRkL2RldmljZXMvbXNtX25hbmQuaCB8ICAgNzcgKysKPiAgNCBmaWxlcyBjaGFu Z2VkLCAxNjg2IGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCj4gIGNyZWF0ZSBtb2RlIDEw MDY0NCBkcml2ZXJzL210ZC9kZXZpY2VzL21zbV9uYW5kLmMKPiAgY3JlYXRlIG1vZGUgMTAwNjQ0 IGRyaXZlcnMvbXRkL2RldmljZXMvbXNtX25hbmQuaAo+IAoKRm9yIHRoZSByZWNvcmQsIEkgYW0g bm90IHN1cmUgaXQgaXMgYSBncmVhdCBpZGVhIHRvIG1ha2UgbmFuZCBkcml2ZXJzCmluZGVwZW5k ZW50IG9mIHRoZSBuYW5kIGxheWVyLgpCeSBkb2luZyB0aGF0IHlvdSBjb3VsZCBjaGFuZ2UgdGhl IGV4cGVjdGVkIGJlaGF2aW9yLCBhbmQgaW50cm9kdWNlIGJ1ZwpkaWZmaWN1bHQgdG8gZGVidWcu CgpXaHkgZG8geW91IG5lZWQgdGhhdCA/IE5hbmQgZHJpdmVycyBjYW4gb3ZlcnJpZGUgY2FsbGJh Y2tzIG9mIG5hbmQgZnJhbWV3b3JrLgoKTWF5YmUgYmVjYXVzZSB0aGUgbmFuZCBsYXllciBjYWxs IHRoZSBkcml2ZXIgcGFnZSBwZXIgcGFnZSwgYW5kICB5b3Ugd2FudCB0bwp3b3JrIHdpdGggbW9y ZSB0aGFuIG9uZSBwYWdlLiBCdXQgaW4gdGhpcyBjYXNlIHlvdSBjYW4gZXh0ZW5kIG5hbmQgbGF5 ZXIuCgpPciBkb2VzIHlvdXIgY29udHJvbGxlciBkb24ndCBhbGxvdyBzZW5kaW5nIHJhdyBjb21t YW5kID8KQW5kIGluIHRoYXQgY2FzZSBhbGwgdGhlIG5hbmQgbG9naWMgaXMgaW4gdGhlIG5hbmQg Y29udHJvbGxlciA/CgpNYXR0aGlldQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <4DABE8FE.5040300@parrot.com> Date: Mon, 18 Apr 2011 09:32:14 +0200 From: Matthieu CASTET MIME-Version: 1.0 To: Murali Nalajala Subject: Re: [PATCH V2 2/2] mtd: msm_nand: Add initial msm nand driver support. References: <1302938249-4601-1-git-send-email-mnalajal@codeaurora.org> In-Reply-To: <1302938249-4601-1-git-send-email-mnalajal@codeaurora.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Cc: "linux-arm-msm@vger.kernel.org" , Dima Zavin , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , "linux-mtd@lists.infradead.org" , Brian Swetland , "dwmw2@infradead.org" , "linux-arm-kernel@lists.infradead.org" List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi, Murali Nalajala a écrit : > Add initial msm nand driver support for Qualcomm MSM platforms. > This driver is capable of handling both 2k and 4k page support > nand devices. > > This driver was originally developed by Arve Hjønnevåg at google. > Its source is available at > http://android.git.kernel.org/?p=kernel/msm.git under > android-msm-2.6.35 branch. > > CC: Dima Zavin > CC: Brian Swetland > CC: Arve Hjønnevåg > Signed-off-by: Murali Nalajala > --- > Changes in V2 > * Turn most of the pr_info() calls into pr_debug(). > > drivers/mtd/devices/Kconfig | 11 + > drivers/mtd/devices/Makefile | 1 + > drivers/mtd/devices/msm_nand.c | 1597 ++++++++++++++++++++++++++++++++++++++++ > drivers/mtd/devices/msm_nand.h | 77 ++ > 4 files changed, 1686 insertions(+), 0 deletions(-) > create mode 100644 drivers/mtd/devices/msm_nand.c > create mode 100644 drivers/mtd/devices/msm_nand.h > For the record, I am not sure it is a great idea to make nand drivers independent of the nand layer. By doing that you could change the expected behavior, and introduce bug difficult to debug. Why do you need that ? Nand drivers can override callbacks of nand framework. Maybe because the nand layer call the driver page per page, and you want to work with more than one page. But in this case you can extend nand layer. Or does your controller don't allow sending raw command ? And in that case all the nand logic is in the nand controller ? Matthieu From mboxrd@z Thu Jan 1 00:00:00 1970 From: matthieu.castet@parrot.com (Matthieu CASTET) Date: Mon, 18 Apr 2011 09:32:14 +0200 Subject: [PATCH V2 2/2] mtd: msm_nand: Add initial msm nand driver support. In-Reply-To: <1302938249-4601-1-git-send-email-mnalajal@codeaurora.org> References: <1302938249-4601-1-git-send-email-mnalajal@codeaurora.org> Message-ID: <4DABE8FE.5040300@parrot.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, Murali Nalajala a ?crit : > Add initial msm nand driver support for Qualcomm MSM platforms. > This driver is capable of handling both 2k and 4k page support > nand devices. > > This driver was originally developed by Arve Hj?nnev?g at google. > Its source is available at > http://android.git.kernel.org/?p=kernel/msm.git under > android-msm-2.6.35 branch. > > CC: Dima Zavin > CC: Brian Swetland > CC: Arve Hj?nnev?g > Signed-off-by: Murali Nalajala > --- > Changes in V2 > * Turn most of the pr_info() calls into pr_debug(). > > drivers/mtd/devices/Kconfig | 11 + > drivers/mtd/devices/Makefile | 1 + > drivers/mtd/devices/msm_nand.c | 1597 ++++++++++++++++++++++++++++++++++++++++ > drivers/mtd/devices/msm_nand.h | 77 ++ > 4 files changed, 1686 insertions(+), 0 deletions(-) > create mode 100644 drivers/mtd/devices/msm_nand.c > create mode 100644 drivers/mtd/devices/msm_nand.h > For the record, I am not sure it is a great idea to make nand drivers independent of the nand layer. By doing that you could change the expected behavior, and introduce bug difficult to debug. Why do you need that ? Nand drivers can override callbacks of nand framework. Maybe because the nand layer call the driver page per page, and you want to work with more than one page. But in this case you can extend nand layer. Or does your controller don't allow sending raw command ? And in that case all the nand logic is in the nand controller ? Matthieu