From: Felix Fietkau <nbd@openwrt.org>
To: Sujith <m.sujith@gmail.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
lrodriguez@atheros.com, jouni.malinen@atheros.com
Subject: Re: [PATCH 1/2] ath9k: fix powersave frame filtering/buffering in AP mode
Date: Mon, 18 Apr 2011 13:27:18 +0200 [thread overview]
Message-ID: <4DAC2016.3000008@openwrt.org> (raw)
In-Reply-To: <19884.7222.186200.867910@gargle.gargle.HOWL>
On 2011-04-18 1:10 PM, Sujith wrote:
> Felix Fietkau wrote:
>> The driver calls ieee80211_sta_set_tim on STA_NOTIFY_SLEEP whenever it
>> still has some buffered frames that it intends to keep until the client
>> wakes up again (i.e. frames that will not be returned to mac80211 as
>> filtered).
>
> Why should ieee80211_sta_set_tim() be called from complete_aggr() ?
I should probably add an extra check that tests for tid->buf_q being
empty - and some comments.
This handles a race condition that occurs if an A-MPDU completes (with
some pending frames) after the station entered PS and
ieee80211_sta_set_tim was not called because the buffer queue was empty.
- Felix
next prev parent reply other threads:[~2011-04-18 11:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-17 21:28 [PATCH 1/2] ath9k: fix powersave frame filtering/buffering in AP mode Felix Fietkau
2011-04-17 21:28 ` [PATCH 2/2] ath9k: assign keycache slots to unencrypted stations Felix Fietkau
2011-04-18 4:26 ` [PATCH 1/2] ath9k: fix powersave frame filtering/buffering in AP mode Sujith
2011-04-18 8:54 ` Felix Fietkau
2011-04-18 11:10 ` Sujith
2011-04-18 11:27 ` Felix Fietkau [this message]
2011-04-18 11:45 ` Sujith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DAC2016.3000008@openwrt.org \
--to=nbd@openwrt.org \
--cc=jouni.malinen@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=m.sujith@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.