All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
To: Chris Mason <chris.mason@oracle.com>
Cc: LKML <linux-kernel@vger.kernel.org>, BTRFS <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 1/2] Btrfs: allocate extent state and check the result properly
Date: Tue, 19 Apr 2011 09:49:52 +0800	[thread overview]
Message-ID: <4DACEA40.5020008@cn.fujitsu.com> (raw)
In-Reply-To: <4DA409E6.7020406@cn.fujitsu.com>

On 04/12/2011 04:14 PM, Xiao Guangrong wrote:
> It doesn't allocate extent_state and check the result properly:
> - in set_extent_bit, it doesn't allocate extent_state if the path is not
>   allowed wait
> 
> - in clear_extent_bit, it doesn't check the result after atomic-ly allocate,
>   we trigger BUG_ON() if it's fail
> 
> - if allocate fail, we trigger BUG_ON instead of returning -ENOMEM since
>   the return value of clear_extent_bit() is ignored by many callers
> 

Ping...to see what happened. :-)

  parent reply	other threads:[~2011-04-19  1:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-12  8:14 [PATCH 1/2] Btrfs: allocate extent state and check the result properly Xiao Guangrong
2011-04-12  8:15 ` [PATCH 2/2] Btrfs: fix unsafe usage of merge_state Xiao Guangrong
2011-04-19  1:49 ` Xiao Guangrong [this message]
2011-04-19 11:55   ` [PATCH 1/2] Btrfs: allocate extent state and check the result properly Chris Mason
2011-04-20  6:49     ` Xiao Guangrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DACEA40.5020008@cn.fujitsu.com \
    --to=xiaoguangrong@cn.fujitsu.com \
    --cc=chris.mason@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.