From: Jonathan Cameron <jic23@cam.ac.uk>
To: michael.hennerich@analog.com
Cc: linux-iio@vger.kernel.org, drivers@analog.com,
device-drivers-devel@blackfin.uclinux.org
Subject: Re: [PATCH] IIO-onwards: ADC: free pollfunc->name on remove
Date: Tue, 19 Apr 2011 11:58:03 +0100 [thread overview]
Message-ID: <4DAD6ABB.8070407@cam.ac.uk> (raw)
In-Reply-To: <1303197557-32421-1-git-send-email-michael.hennerich@analog.com>
On 04/19/11 08:19, michael.hennerich@analog.com wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
>
>
Thanks, will merge fixes into the patches that introduced the bug.
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
> ---
> drivers/staging/iio/adc/ad7476_ring.c | 2 +-
> drivers/staging/iio/adc/max1363_ring.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/ad7476_ring.c b/drivers/staging/iio/adc/ad7476_ring.c
> index b6da824..de6006b 100644
> --- a/drivers/staging/iio/adc/ad7476_ring.c
> +++ b/drivers/staging/iio/adc/ad7476_ring.c
> @@ -109,7 +109,6 @@ done:
> return IRQ_HANDLED;
> }
>
> -
> static struct iio_ring_setup_ops ad7476_ring_setup_ops = {
> .preenable = &ad7476_ring_preenable,
> .postenable = &iio_triggered_ring_postenable,
> @@ -168,6 +167,7 @@ void ad7476_ring_cleanup(struct iio_dev *indio_dev)
> iio_trigger_dettach_poll_func(indio_dev->trig,
> indio_dev->pollfunc);
> }
> + kfree(indio_dev->pollfunc->name);
> kfree(indio_dev->pollfunc);
> iio_sw_rb_free(indio_dev->ring);
> }
> diff --git a/drivers/staging/iio/adc/max1363_ring.c b/drivers/staging/iio/adc/max1363_ring.c
> index b8054be..da6b4f6 100644
> --- a/drivers/staging/iio/adc/max1363_ring.c
> +++ b/drivers/staging/iio/adc/max1363_ring.c
> @@ -210,6 +210,7 @@ void max1363_ring_cleanup(struct iio_dev *indio_dev)
> iio_trigger_dettach_poll_func(indio_dev->trig,
> indio_dev->pollfunc);
> }
> + kfree(indio_dev->pollfunc->name);
> kfree(indio_dev->pollfunc);
> iio_sw_rb_free(indio_dev->ring);
> }
prev parent reply other threads:[~2011-04-19 10:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 7:19 [PATCH] IIO-onwards: ADC: free pollfunc->name on remove michael.hennerich
2011-04-19 10:58 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DAD6ABB.8070407@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=drivers@analog.com \
--cc=linux-iio@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.