All of lore.kernel.org
 help / color / mirror / Atom feed
From: jochen@scram.de (Jochen Friedrich)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 2.6.40 3/3] ARM:simpad: add GPIO based device definitions.
Date: Tue, 19 Apr 2011 16:46:32 +0200	[thread overview]
Message-ID: <4DADA048.2090306@scram.de> (raw)
In-Reply-To: <20110419135210.GA2182@rainbow>

Hi Dmitry,

>>   arch/arm/mach-sa1100/Makefile      |    1 -
>>   arch/arm/mach-sa1100/leds-simpad.c |   97 ------------------------------------
>>   arch/arm/mach-sa1100/simpad.c      |   95 ++++++++++++++++++++++++++++++++++-
>>   3 files changed, 94 insertions(+), 99 deletions(-)
>>   delete mode 100644 arch/arm/mach-sa1100/leds-simpad.c
>
> But, while removing leds-simpad.c, it seems you forgot to update both
> Makefile and corresponding entries in leds.[ch], so I suspect it will
> break build with CONFIG_LEDS=y.

Thanks for the review. I'll update my patch.

> And, while you're at it, it's probably a good idea to move all these LED
> changes into separate patch, and not to mix them with gpio-keys/i2c/etc
> devices registration.

I'll seperate the LED stuff from the rest of the patch.

Thanks,
Jochen

      reply	other threads:[~2011-04-19 14:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-18 13:00 [PATCHv2 2.6.40 0/3] ARM: simpad: Add support for GPIO attached hardware Jochen Friedrich
2011-04-18 13:00 ` [PATCHv2 2.6.40 1/3] ARM:simpad: Add ucb1x00 GPIO definitions and register GPIO Jochen Friedrich
2011-04-18 13:00 ` [PATCHv2 2.6.40 2/3] ARM:simpad: Cleanup CS3 accessors Jochen Friedrich
2011-04-18 13:47   ` Jamie Iles
2011-04-18 14:35     ` Jochen Friedrich
2011-04-18 14:46       ` Henning Heinold
2011-04-18 16:49       ` Jamie Iles
2011-04-18 18:02         ` Jochen Friedrich
2011-04-19  9:09           ` Jamie Iles
2011-04-18 13:00 ` [PATCHv2 2.6.40 3/3] ARM:simpad: add GPIO based device definitions Jochen Friedrich
2011-04-19 13:52   ` Dmitry Artamonow
2011-04-19 14:46     ` Jochen Friedrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DADA048.2090306@scram.de \
    --to=jochen@scram.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.