From: Brian Haley <brian.haley@hp.com>
To: Jay Vosburgh <fubar@us.ibm.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>,
David Miller <davem@davemloft.net>,
Andy Gospodarek <andy@greyhouse.net>,
Patrick McHardy <kaber@trash.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6 3/3] bonding,ipv4,ipv6,vlan: Handle NETDEV_BONDING_FAILOVER like NETDEV_NOTIFY_PEERS
Date: Tue, 19 Apr 2011 15:34:00 -0400 [thread overview]
Message-ID: <4DADE3A8.3040206@hp.com> (raw)
In-Reply-To: <26398.1303240321@death>
On 04/19/2011 03:12 PM, Jay Vosburgh wrote:
>>> Brian Haley added the unsolicited NAs; I've added him to the cc
>>> so perhaps he (or somebody else) can comment on the necessity of keeping
>>> the ability to send multiple NAs.
>> [...]
>>
>> How about restoring the parameters like this:
>
> I think the patch below is better than Brian's suggestion (new
> single parameter) because it won't break existing configurations, even
> though it is doing magic under the covers. If the magic is a real
> concern, we could add logic to detect when both parameters are used and
> set to different values, but I'm not really that worked up about it as
> long as the magic is clearly documented.
My patch was on-top of Ben's, it still left the old options around, just
gave people time to notice they didn't work as before. It's not a big
deal either way.
-Brian
next prev parent reply other threads:[~2011-04-19 19:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 23:47 [PATCH net-next-2.6 3/3] bonding,ipv4,ipv6,vlan: Handle NETDEV_BONDING_FAILOVER like NETDEV_NOTIFY_PEERS Ben Hutchings
2011-04-16 0:30 ` Jay Vosburgh
2011-04-16 1:51 ` Brian Haley
2011-04-16 2:53 ` Ben Hutchings
2011-04-18 19:09 ` Ben Hutchings
2011-04-19 1:32 ` Brian Haley
2011-04-19 14:56 ` Ben Hutchings
2011-04-19 19:12 ` Jay Vosburgh
2011-04-19 19:34 ` Brian Haley [this message]
2011-04-22 4:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DADE3A8.3040206@hp.com \
--to=brian.haley@hp.com \
--cc=andy@greyhouse.net \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.