From: Luca Ceresoli <luca@lucaceresoli.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/6] TFTP: rename "server" to "remote"
Date: Tue, 19 Apr 2011 23:56:54 +0200 [thread overview]
Message-ID: <4DAE0526.5080200@lucaceresoli.net> (raw)
In-Reply-To: <m2ei4yi4tn.fsf@ohwell.denx.de>
Hi,
just a few e-mails ago along this thread Albert Aribaud wrote:
> My opinion is that you should make sure that at least the code you touch
> is checkpatch-clean, so yes, you should fix that; but there is no need
> to submit 'checkpatch-compliance' patches. Just fix the line here so
> that checkpatch does not complain.
So I proceeded along that way.
Now Detlev Zundel wrote:
> ...
> Hm, I see. Still, can we have one commit (with "cosmetic" in the
> changelog) that silences checkpatch but does not have any functional
> changes? We really try hard to separate cosmetic from functional
> changes. This makes reviewing (and debugging) so much easier.
While I appreciate the careful review of my patches, I cannot hide
that it is discouraging for new contributors to be requested for
contradictory modifications.
There should be one precise policy, and that should be clearly documented.
http://www.denx.de/wiki/U-Boot/CodingStyle is the place where I would
expect to find it.
Luca
next prev parent reply other threads:[~2011-04-19 21:56 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 9:08 [U-Boot] [RFC] Act as a TFTP server Luca Ceresoli
2011-04-13 11:37 ` Wolfgang Denk
2011-04-13 12:47 ` Luca Ceresoli
2011-04-30 19:53 ` Wolfgang Denk
2011-05-03 12:23 ` Luca Ceresoli
2011-05-03 12:36 ` Wolfgang Denk
2011-05-16 20:57 ` Luca Ceresoli
2011-04-14 10:31 ` Luca Ceresoli
2011-04-14 15:52 ` [U-Boot] [PATCH 0/6] " Luca Ceresoli
2011-04-14 16:13 ` Albert ARIBAUD
2011-04-18 16:19 ` [U-Boot] [PATCH v2 " Luca Ceresoli
2011-04-19 14:05 ` Detlev Zundel
2011-05-17 10:03 ` [U-Boot] [PATCH v3 0/5] " Luca Ceresoli
2011-05-17 10:03 ` [U-Boot] [PATCH v3 1/5] TFTP: replace "server" with "remote" in local variable names Luca Ceresoli
2011-05-19 8:11 ` Detlev Zundel
2011-05-19 19:39 ` Wolfgang Denk
2011-05-17 10:03 ` [U-Boot] [PATCH v3 2/5] TFTP: rename STATE_RRQ to STATE_SEND_RRQ Luca Ceresoli
2011-05-19 8:12 ` Detlev Zundel
2011-05-19 19:39 ` Wolfgang Denk
2011-05-17 10:03 ` [U-Boot] [PATCH v3 3/5] TFTP: net/tftp.c: add server mode receive Luca Ceresoli
2011-05-19 8:13 ` Detlev Zundel
2011-05-19 19:48 ` Wolfgang Denk
2011-05-17 10:03 ` [U-Boot] [PATCH v3 4/5] TFTP: add tftpsrv command Luca Ceresoli
2011-05-19 8:12 ` Detlev Zundel
2011-05-19 19:48 ` Wolfgang Denk
2011-05-17 10:03 ` [U-Boot] [PATCH v3 5/5] net/tftp.c: fix typo Luca Ceresoli
2011-05-19 8:13 ` Detlev Zundel
2011-05-19 19:48 ` Wolfgang Denk
2011-04-18 16:19 ` [U-Boot] [PATCH v2 1/6] README: remove spurious line Luca Ceresoli
2011-04-19 14:07 ` Detlev Zundel
2011-04-18 16:19 ` [U-Boot] [PATCH v2 2/6] NET: pass source IP address to packet handlers Luca Ceresoli
2011-04-19 14:15 ` Detlev Zundel
2011-04-19 15:26 ` Luca Ceresoli
2011-05-12 17:38 ` Wolfgang Denk
2011-04-18 16:19 ` [U-Boot] [PATCH v2 3/6] TFTP: rename "server" to "remote" Luca Ceresoli
2011-04-19 14:18 ` Detlev Zundel
2011-04-19 15:29 ` Luca Ceresoli
2011-04-19 16:28 ` Detlev Zundel
2011-04-19 21:56 ` Luca Ceresoli [this message]
2011-04-20 8:17 ` Detlev Zundel
2011-05-04 7:58 ` Luca Ceresoli
2011-05-04 10:37 ` Detlev Zundel
2011-04-20 8:41 ` Detlev Zundel
2011-04-20 10:55 ` Luca Ceresoli
2011-04-20 13:27 ` [U-Boot] checkpatch - theory and practice [was: [PATCH v2 3/6] TFTP: rename "server" to "remote"] Detlev Zundel
2011-05-16 20:35 ` [U-Boot] [PATCH v2 3/6] TFTP: rename "server" to "remote" Luca Ceresoli
2011-05-17 9:38 ` Detlev Zundel
2011-04-30 4:36 ` Mike Frysinger
2011-05-16 20:16 ` Luca Ceresoli
2011-05-12 17:46 ` Wolfgang Denk
2011-05-13 7:36 ` Luca Ceresoli
2011-05-14 16:07 ` Luca Ceresoli
2011-04-18 16:19 ` [U-Boot] [PATCH v2 4/6] TFTP: rename STATE_RRQ to STATE_SEND_RRQ Luca Ceresoli
2011-04-19 14:22 ` Detlev Zundel
2011-04-18 16:19 ` [U-Boot] [PATCH v2 5/6] TFTP: net/tftp.c: add server mode receive Luca Ceresoli
2011-04-19 14:37 ` Detlev Zundel
2011-05-17 8:06 ` Luca Ceresoli
2011-05-17 9:41 ` Detlev Zundel
2011-04-18 16:19 ` [U-Boot] [PATCH v2 6/6] TFTP: add tftpsrv command Luca Ceresoli
2011-04-19 14:39 ` Detlev Zundel
2011-04-30 4:32 ` Mike Frysinger
2011-05-04 7:02 ` Mike Frysinger
2011-04-14 15:52 ` [U-Boot] [PATCH 1/6] README: remove spurious line Luca Ceresoli
2011-04-30 20:19 ` Wolfgang Denk
2011-04-14 15:52 ` [U-Boot] [PATCH 2/6] NET: pass source IP address to packet handlers Luca Ceresoli
2011-04-30 20:22 ` Wolfgang Denk
2011-04-30 20:24 ` Wolfgang Denk
2011-05-03 8:54 ` Luca Ceresoli
2011-04-14 15:52 ` [U-Boot] [PATCH 3/6] TFTP: rename "server" to "remote" Luca Ceresoli
2011-04-14 15:52 ` [U-Boot] [PATCH 4/6] TFTP: rename STATE_RRQ to STATE_SEND_RRQ Luca Ceresoli
2011-04-14 15:52 ` [U-Boot] [PATCH 5/6] TFTP: net/tftp.c: add server mode receive Luca Ceresoli
2011-04-14 15:52 ` [U-Boot] [PATCH 6/6] TFTP: add tftpsrv command Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DAE0526.5080200@lucaceresoli.net \
--to=luca@lucaceresoli.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.