From: Avi Kivity <avi@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: linux-pci@vger.kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, jan.kiszka@siemens.com,
jbarnes@virtuousgeek.org
Subject: Re: [PATCH v2 0/2] Store and load PCI device saved state across function resets
Date: Wed, 20 Apr 2011 11:19:22 +0300 [thread overview]
Message-ID: <4DAE970A.50603@redhat.com> (raw)
In-Reply-To: <20110419200912.3739.22895.stgit@s20.home>
On 04/19/2011 11:12 PM, Alex Williamson wrote:
> v1 -> v2:
> Make the pointer passed around less opaque for type safety.
>
> Bug https://bugs.launchpad.net/qemu/+bug/754591 is caused because
> the KVM module attempts to do a pci_save_state() before assigning
> the device to a VM, expecting that the saved state will remain
> valid until we release the device. This is in conflict with our
> need to reset devices using PCI sysfs during a VM reset to
> quiesce the device. Any calls to pci_reset_function() will
> overwrite the device saved stated prior to reset, and reload and
> invalidate the state after. KVM then ends up trying to restore
> the state, but it's already invalid, so the device ends up with
> reset values.
>
> This series adds a mechanism to pull the saved state off the
> struct pci_dev and reload it later. Thanks,
Based on the sizes of the patches, this should go in via the pci tree.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2011-04-20 8:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 20:12 [PATCH v2 0/2] Store and load PCI device saved state across function resets Alex Williamson
2011-04-19 20:12 ` [PATCH v2 1/2] PCI: Add interfaces to store and load the device saved state Alex Williamson
2011-04-19 20:12 ` [PATCH v2 2/2] KVM: Use pci_store/load_saved_state() around VM device usage Alex Williamson
2011-04-20 8:19 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DAE970A.50603@redhat.com \
--to=avi@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=jbarnes@virtuousgeek.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.