From: Avi Kivity <avi@redhat.com>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org, Juan Quintela <quintela@redhat.com>
Subject: Re: [PATCH] acpi_piix4: remove bad save/restore of cpus_sts
Date: Wed, 20 Apr 2011 11:24:25 +0300 [thread overview]
Message-ID: <4DAE9839.1020902@redhat.com> (raw)
In-Reply-To: <20110418135658.GE21865@valinux.co.jp>
On 04/18/2011 04:56 PM, Isaku Yamahata wrote:
> This patch would fix the segfaults. But I suppose the followings
> are necessary.
>
> - PIIX4PMState::gpe_cpu needs to be saved/loaded somewhere
Yes. Juan?
> - gpe_writeb() needs to handle PROC_BASE ... PROC_BASE+31
> like gpe_readb(). To be honest, I don't see why gpe_readb/writeb()
> are used for PROC_BASE...PROC_BASE + 31
>
Even before the merge, we didn't handle a write to this address.
Perhaps it's read-only? (that should explain no save/restore).
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2011-04-20 8:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-18 8:44 [PATCH] acpi_piix4: remove bad save/restore of cpus_sts Avi Kivity
2011-04-18 13:56 ` Isaku Yamahata
2011-04-18 14:10 ` Isaku Yamahata
2011-04-20 8:24 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DAE9839.1020902@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=quintela@redhat.com \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.