From: Daniel Hellstrom <daniel@gaisler.com>
To: sparclinux@vger.kernel.org
Subject: Re: [PATCH 6/7] sparc32,leon: operate on boot-cpu IRQ controller
Date: Wed, 20 Apr 2011 11:25:35 +0000 [thread overview]
Message-ID: <4DAEC2AF.5010902@gaisler.com> (raw)
In-Reply-To: <1303229239-21551-6-git-send-email-daniel@gaisler.com>
Daniel Hellstrom wrote:
> Josip Rodin wrote:
>
>> On Wed, Apr 20, 2011 at 11:06:54AM +0200, Sam Ravnborg wrote:
>>
>>
>>> [PATCH]sparc32: always define boot_cpu_id
>>>
>>> +extern unsigned char boot_cpu_id;
>>> +unsigned char boot_cpu_id;
>>> -unsigned char boot_cpu_id = 0;
>>> - int target_cpu = 0;
>>> + int target_cpu;
>>> target_cpu = boot_cpu_id;
>>>
>>
>>
>> You declared it, but you didn't actually define it?
>>
>>
> There is an error in this patch, setup.h include is missing. I will
> repost.
I will not repost at this point. I think this is broken in sparc32
anyway. boot_cpu_id is always 0 because it is initialized before BSS is
cleared, and boot_cpu_id is part of BSS. see arch/sparc/kernel/head_32.S
Daniel
prev parent reply other threads:[~2011-04-20 11:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 16:07 [PATCH 6/7] sparc32,leon: operate on boot-cpu IRQ controller registers Daniel Hellstrom
2011-04-19 18:47 ` [PATCH 6/7] sparc32,leon: operate on boot-cpu IRQ controller Sam Ravnborg
2011-04-20 7:02 ` Daniel Hellstrom
2011-04-20 7:39 ` crn
2011-04-20 8:12 ` Daniel Hellstrom
2011-04-20 8:15 ` David Miller
2011-04-20 8:35 ` Daniel Hellstrom
2011-04-20 8:39 ` David Miller
2011-04-20 8:44 ` Daniel Hellstrom
2011-04-20 8:45 ` David Miller
2011-04-20 8:46 ` crn
2011-04-20 9:06 ` Sam Ravnborg
2011-04-20 9:38 ` Josip Rodin
2011-04-20 10:44 ` Sam Ravnborg
2011-04-20 10:47 ` Daniel Hellstrom
2011-04-20 11:25 ` Daniel Hellstrom [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DAEC2AF.5010902@gaisler.com \
--to=daniel@gaisler.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.