From: Dimitris Michailidis <dm@chelsio.com>
To: Shirley Ma <mashirle@us.ibm.com>
Cc: David Miller <davem@davemloft.net>,
mst@redhat.com, Eric Dumazet <eric.dumazet@gmail.com>,
Avi Kivity <avi@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
netdev@vger.kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 5/8] Enable cxgb3 to support zerocopy
Date: Wed, 20 Apr 2011 13:52:45 -0700 [thread overview]
Message-ID: <4DAF479D.7090309@chelsio.com> (raw)
In-Reply-To: <1303330438.19336.57.camel@localhost.localdomain>
On 04/20/2011 01:13 PM, Shirley Ma wrote:
> Signed-off-by: Shirley Ma <xma@us.ibm.com>
> ---
>
> drivers/net/cxgb3/cxgb3_main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cxgb3/cxgb3_main.c
> index 9108931..93a1101 100644
> --- a/drivers/net/cxgb3/cxgb3_main.c
> +++ b/drivers/net/cxgb3/cxgb3_main.c
> @@ -3313,7 +3313,7 @@ static int __devinit init_one(struct pci_dev *pdev,
> netdev->features |= NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_TSO;
> netdev->features |= NETIF_F_GRO;
> if (pci_using_dac)
> - netdev->features |= NETIF_F_HIGHDMA;
> + netdev->features |= NETIF_F_HIGHDMA | NETIF_F_ZEROCOPY;
>
> netdev->features |= NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX;
> netdev->netdev_ops = &cxgb_netdev_ops;
The features handling has been reworked in net-next and patches like this
won't apply as the code you're patching has changed. Also core code now
does a lot of the related work and you'll need to tell it what to do with
any new flags.
What properties does a device or driver need to meet to set this flag? It
seems to be set a bit too unconditionally. For example, does it work if one
disables scatter/gather?
next prev parent reply other threads:[~2011-04-20 20:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 19:36 [PATCH V3 0/8] macvtap/vhost TX zero copy support Shirley Ma
2011-04-20 19:42 ` [PATCH V3 1/8] Add a new sock zerocopy flag Shirley Ma
2011-04-20 19:44 ` [PATCH V3 2/8] Add a new zerocopy device flag Shirley Ma
2011-04-20 19:48 ` Ben Hutchings
2011-04-20 20:05 ` Shirley Ma
2011-04-20 20:09 ` Shirley Ma
2011-04-20 20:24 ` Dimitris Michailidis
2011-04-20 20:28 ` Shirley Ma
2011-04-20 20:30 ` Shirley Ma
2011-05-02 10:42 ` Michael S. Tsirkin
2011-05-02 18:47 ` Shirley Ma
2011-05-02 19:53 ` Michael S. Tsirkin
2011-05-03 17:42 ` Shirley Ma
2011-05-03 20:11 ` Shirley Ma
2011-04-20 19:47 ` [PATCH V3 3/8] Add userspace buffers support in skb Shirley Ma
2011-05-02 10:53 ` Michael S. Tsirkin
2011-05-03 17:36 ` Shirley Ma
2011-04-20 20:07 ` [PATCH V3 4/8] vhost TX zero copy support Shirley Ma
2011-04-20 20:12 ` [PATCH V3 0/8] macvtap/vhost " Shirley Ma
2011-04-20 20:13 ` [PATCH V3 5/8] Enable cxgb3 to support zerocopy Shirley Ma
2011-04-20 20:52 ` Dimitris Michailidis [this message]
2011-04-20 20:58 ` Shirley Ma
2011-04-20 21:15 ` Shirley Ma
2011-04-20 20:15 ` [PATCH V3 7/8] Enable ixgbe " Shirley Ma
2011-04-20 20:17 ` [PATCH V3 8/8] Enable benet " Shirley Ma
2011-04-20 20:27 ` [PATCH V3 6/8] macvtap/vhost TX zero copy support Shirley Ma
2011-05-02 18:35 ` Shirley Ma
2011-04-21 14:29 ` [PATCH V3 0/8] " Jon Mason
2011-04-22 17:31 ` Shirley Ma
2011-04-22 17:52 ` Shirley Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DAF479D.7090309@chelsio.com \
--to=dm@chelsio.com \
--cc=arnd@arndb.de \
--cc=avi@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mashirle@us.ibm.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.