Re: [PATCH] ASoC: tegra: TrimSlice machine support

[Mike Rapoport <mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>]

On 04/18/11 17:40, Mark Brown wrote:
> On Sun, Apr 17, 2011 at 08:45:22AM -0700, Stephen Warren wrote:
> 
>> // First line cribbed from tlv320aic3x.c.
>> // Yes, that's not the codec here, but the logic applies I think.
>> fsref = (srate % 11025 == 0) ? 44100 : 48000;
>> mclk = 256 * fsref;
> 
> That's pretty much illegible due to the ternery operator and...
> 
>> ... although the rate calculations in tlv320aic23.c are more complex, so
>> I could be persuaded otherwise.
> 
> ...it's for a completely different CODEC with different requirements and
> features.
> 

I've run several tests and the codec seems to be pretty happy when
mclk = 128 * srate
so I'd prefer to keep things simple and green :)


-- 
Sincerely yours,
Mike.