All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: vikas.chaudhary@qlogic.com
Cc: James.Bottomley@suse.de, linux-scsi@vger.kernel.org,
	lalit.chandivade@qlogic.com, ravi.anand@qlogic.com
Subject: Re: [PATCH 4/5] iscsi_transport: show network configuration in sysfs
Date: Sat, 23 Apr 2011 17:40:11 -0500	[thread overview]
Message-ID: <4DB3554B.4080505@cs.wisc.edu> (raw)
In-Reply-To: <1303495666-731-5-git-send-email-vikas.chaudhary@qlogic.com>

On 04/22/2011 01:07 PM, vikas.chaudhary@qlogic.com wrote:
> From: Vikas Chaudhary<vikas.chaudhary@qlogic.com>
>
> To support multiple network addresses per adapter need to have a new way to
> represent network interface (net iface) in sysfs.
>

 From the previous posting's comments you did not handle or respond to 
the comment about linking the sessions to the iface. Basically, I want 
to know how for sessionX you know which iface is being used? For 
example, users want to know the src ip address for the session.

You could make a symlink from the session to the iface or make the iface 
the parent of the session instead of the host then add symlinks to/from, 
for compat with existing tools, the session/host.

We could do this in another patch, but I would then want to wait off on 
sending this patch and the 5/5 to James so we do not have some kernels 
with it and some without.

  reply	other threads:[~2011-04-23 22:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-22 18:07 [PATCH 0/5] qla4xxx: Proposal for iSCSI Network Configuration vikas.chaudhary
2011-04-22 18:07 ` [PATCH 1/5] iscsi_transport: add support for set_net_config vikas.chaudhary
2011-04-23  5:19   ` Mike Christie
2011-04-22 18:07 ` [PATCH 2/5] qla4xxx: " vikas.chaudhary
2011-04-22 18:07 ` [PATCH 3/5] qla4xxx: Added new "struct ipaddress_config" vikas.chaudhary
2011-04-22 18:07 ` [PATCH 4/5] iscsi_transport: show network configuration in sysfs vikas.chaudhary
2011-04-23 22:40   ` Mike Christie [this message]
2011-04-22 18:07 ` [PATCH 5/5] qla4xxx: added support to show multiple iface " vikas.chaudhary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DB3554B.4080505@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=James.Bottomley@suse.de \
    --cc=lalit.chandivade@qlogic.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=ravi.anand@qlogic.com \
    --cc=vikas.chaudhary@qlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.