Re: [PATCH 1/1 v2] KVM: MMU: Optimize guest page table walk

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 746 bytes --]

On 2011-04-25 10:32, Takuya Yoshikawa wrote:
> On Mon, 25 Apr 2011 10:04:43 +0200
> Jan Kiszka <jan.kiszka@web.de> wrote:
> 
>>> +
>>> +		ptep_user = (pt_element_t __user *)((void *)host_addr + offset);
>>> +		if (get_user(pte, ptep_user)) {
>>                     ^^^^^^^^^^^^
>> This doesn't work for x86-32: pte is 64 bit, but get_user is only
>> defined up to 32 bit on that platform.
>>
>> Avi, what's your 32-bit buildbot doing? :)
>>
>> Jan
>>
> 
> Sorry, I did not test on x86_32.
> 
> Introducing a wrapper function with ifdef would be the best way?
> 

Maybe you could also add the missing 64-bit get_user for x86-32. Given
that we have a corresponding put_user, I wonder why the get_user was
left out.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]