Re: [PATCH 3/3] bluez4: Add 4.91 and make it default for Angstrom

[Tom Rini <tom_rini@mentor.com>]

On 04/25/2011 11:54 AM, Paul Menzel wrote:
> Dear Tom,
> 
> 
> On Mo, 2011-04-25 at 11:31 -0700, Tom Rini wrote:
> 
> what build configuration did you use for build testing? Could you add
> that to the commit message please.

Done.

>> Signed-off-by: Tom Rini <tom_rini@mentor.com>
>> ---
>>  recipes/bluez/bluez4_4.91.bb |   18 ++++++++++++++++++
>>  1 files changed, 18 insertions(+), 0 deletions(-)
>>  create mode 100644 recipes/bluez/bluez4_4.91.bb
>>
>> diff --git a/recipes/bluez/bluez4_4.91.bb b/recipes/bluez/bluez4_4.91.bb
>> new file mode 100644
>> index 0000000..16f06d5
>> --- /dev/null
>> +++ b/recipes/bluez/bluez4_4.91.bb
>> @@ -0,0 +1,18 @@
>> +require bluez4.inc
>> +
>> +SRC_URI[md5sum] = "3059b7ef5168c84cd0c6a67034ce79f9"
>> +SRC_URI[sha256sum] = "11e9279e2669db996afd464b96d2c68f41f157f6eb9b8842a0bbcad8a4eac18d"
>> +
>> +DEFAULT_PREFERENCE = "-1"
>> +DEFAULT_PREFERENCE_angstrom = "1"
>> +
>> +DEPENDS += "libsndfile1"
>> +
>> +PR = "${INC_PR}.0"
>> +
>> +# Not all distros have a recent enough udev
>> +BTUDEV = " --disable-udevrules"
>> +BTUDEV_angstrom = " --enable-udevrules"
>> +BTUDEV_shr = " --enable-udevrules"
>> +
>> +EXTRA_OECONF += "${BTUDEV}"
> 
> Please create the patch next time adding `-M -C -C` to `git
> format-patch`.

Is there a way to shove that into ~/.gitconfig?  Otherwise I'm sure to
forget.

> Additionally adding the recipe and making it default for
> Ȧngström could have been two commits in my opinion.

That's a little excessive I think, just because it's largely a given
that Angstrom (and SHR) will be opting to use this and it doesn't add
anything to the bisect'ability of the tree.

> Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>

Just for this one patch I assume.

-- 
Tom Rini
Mentor Graphics Corporation