Re: [PATCH 0/1] Rename creat-lsb-image and improve some functions in script

[Darren Hart <dvhart@linux.intel.com>]

Hi Xiaofeng,

Thanks for accepting all the feedback you received and working through
another patch.

As a matter of process (for the future) please remember to:

1) make sure people who influenced a patch rewrite are CC'd on it
2) Separate patches into logical blocks
   o white space fixes
   o renames
   o contained functional changes

#1 gives the reviewers an opportunity to perform a follow-up review and
   ensure the feedback was communicated and received correctly.

#2 is important as with the patch below, the rename and the functional
   changes are merged into a single patch, so important changes are
   invisible, making it very difficult to review. Also, if a problem
   is detected with this file, it is now impossible to revert the
   functional change without also renaming the file.

Thanks,

Darren Hart

On 04/24/2011 09:44 PM, Saul Wold wrote:
> On 04/22/2011 02:04 AM, Xiaofeng Yan wrote:
>> From: Xiaofeng Yan<xiaofeng.yan@windriver.com>
>>
>> Thank Darren Hart and Robert to give me suggestions which make this script more professional.
>> The function for this script is to create a 8G lsb image with lsb test suite.
>> Changes for this script:
>> 1 Correct name of this script
>> 2 Improve some function
>>
>> Pull URL: git://git.pokylinux.org/poky-contrib.git
>>    Branch: xiaofeng/Modify_creat-lsb-image
>>    Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=xiaofeng/Modify_creat-lsb-image
>>
>> Thanks,
>>      Xiaofeng Yan<xiaofeng.yan@windriver.com>
>> ---
>>
>>
>> Xiaofeng Yan (1):
>>    create-lsb-image:Rename creat-lsb-image and improve some function
>>
>>   scripts/creat-lsb-image  |  198 ----------------------------------------
>>   scripts/create-lsb-image |  228 ++++++++++++++++++++++++++++++++++++++++++++++
>>   2 files changed, 228 insertions(+), 198 deletions(-)
>>   delete mode 100755 scripts/creat-lsb-image
>>   create mode 100755 scripts/create-lsb-image
>>
>> _______________________________________________
>> poky mailing list
>> poky@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/poky
>>
> Pulled into oe-core and poky/master
> 
> Thanks
> 	Sau!
> 
> _______________________________________________
> poky mailing list
> poky@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel