From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by mx1.pokylinux.org (Postfix) with ESMTP id 1C1EB4C80ACE for ; Mon, 25 Apr 2011 19:22:09 -0500 (CDT) Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga101.ch.intel.com with ESMTP; 25 Apr 2011 17:22:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.64,267,1301900400"; d="scan'208";a="425360081" Received: from unknown (HELO [10.255.12.237]) ([10.255.12.237]) by azsmga001.ch.intel.com with ESMTP; 25 Apr 2011 17:22:08 -0700 Message-ID: <4DB6102F.7090007@intel.com> Date: Mon, 25 Apr 2011 17:22:07 -0700 From: Saul Wold User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Thunderbird/3.0.5 MIME-Version: 1.0 To: Scott Garman References: <4bc9d84777225d0cfe23672f290c903f72f28a7a.1303761875.git.scott.a.garman@intel.com> In-Reply-To: <4bc9d84777225d0cfe23672f290c903f72f28a7a.1303761875.git.scott.a.garman@intel.com> Cc: poky@yoctoproject.org Subject: Re: [PATCH 1/2] cdrtools: recipe and patch cleanup X-BeenThere: poky@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Poky build system developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2011 00:22:09 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 04/25/2011 01:08 PM, Scott Garman wrote: > From: Scott Garman > > * Recipe cleanup, added missing metadata fields and fixed > whitespace issues > * Added Upstream-Status to patches > * Confirmed that CVE-2003-0655 does not apply to this recipe > as rscsi is not packaged > Scott, You need to add SRC_URI to this recipe. Thanks Sau! > Signed-off-by: Scott Garman > --- > .../cdrtools-native/glibc-conflict-rename.patch | 8 +++++++ > .../cdrtools/cdrtools-native/no_usr_src.patch | 7 ++++++ > .../cdrtools/cdrtools-native_2.01.bb | 21 ++++++++++--------- > 3 files changed, 26 insertions(+), 10 deletions(-) > > diff --git a/meta/recipes-devtools/cdrtools/cdrtools-native/glibc-conflict-rename.patch b/meta/recipes-devtools/cdrtools/cdrtools-native/glibc-conflict-rename.patch > index 0b9b892..2fd5696 100644 > --- a/meta/recipes-devtools/cdrtools/cdrtools-native/glibc-conflict-rename.patch > +++ b/meta/recipes-devtools/cdrtools/cdrtools-native/glibc-conflict-rename.patch > @@ -1,3 +1,11 @@ > +This patch fixes collisions between locally defined functions > +and glibc's fexecve() and getline() functions. > + > +Upstream-Status: Inappropriate [Other] > +Upstream no longer maintains a GPL version of this utility. > + > +Signed-off-by: Scott Garman > + > Index: cdrtools-2.01/include/schily.h > =================================================================== > --- cdrtools-2.01.orig/include/schily.h 2009-06-18 11:30:45.000000000 +0100 > diff --git a/meta/recipes-devtools/cdrtools/cdrtools-native/no_usr_src.patch b/meta/recipes-devtools/cdrtools/cdrtools-native/no_usr_src.patch > index 0318d31..82e57d1 100644 > --- a/meta/recipes-devtools/cdrtools/cdrtools-native/no_usr_src.patch > +++ b/meta/recipes-devtools/cdrtools/cdrtools-native/no_usr_src.patch > @@ -1,3 +1,10 @@ > +Remove hard-coded references to /usr/src/linux/include to avoid > +host contamination. > + > +Upstream-Status: [Other (build-system specific)] > + > +Signed-off-by: Scott Garman > + > Index: cdrtools-2.01/DEFAULTS/Defaults.gnu > =================================================================== > --- cdrtools-2.01.orig/DEFAULTS/Defaults.gnu 2008-09-22 12:42:12.000000000 +0100 > diff --git a/meta/recipes-devtools/cdrtools/cdrtools-native_2.01.bb b/meta/recipes-devtools/cdrtools/cdrtools-native_2.01.bb > index 769e5e2..edebf57 100644 > --- a/meta/recipes-devtools/cdrtools/cdrtools-native_2.01.bb > +++ b/meta/recipes-devtools/cdrtools/cdrtools-native_2.01.bb > @@ -1,21 +1,22 @@ > # cdrtools-native OE build file > # Copyright (C) 2004-2006, Advanced Micro Devices, Inc. All Rights Reserved > # Released under the MIT license (see packages/COPYING) > - > -LICENSE="GPL" > -DESCRIPTION="A set of tools for CD recording, including cdrecord" > -HOMEPAGE="http://cdrecord.berlios.de/old/private/cdrecord.html" > -PR = "r2" > - > +SUMMARY = "A set of tools for CD recording, including cdrecord" > +DESCRIPTION = "A set of tools for CD recording, including cdrecord" > +HOMEPAGE = "http://cdrecord.berlios.de/private/cdrecord.html" > +SECTION = "console/utils" > +PRIORITY = "optional" > +LICENSE = "GPLv2" > LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f" > +PR = "r2" > > -SRC_URI="ftp://ftp.berlios.de/pub/cdrecord/cdrtools-${PV}.tar.bz2 \ > - file://no_usr_src.patch;patch=1 \ > - file://glibc-conflict-rename.patch;patch=1" > +SRC_URI = "ftp://ftp.berlios.de/pub/cdrecord/cdrtools-${PV}.tar.bz2 \ > + file://no_usr_src.patch \ > + file://glibc-conflict-rename.patch" > > inherit native > > -STAGE_TEMP="${WORKDIR}/image-temp" > +STAGE_TEMP = "${WORKDIR}/image-temp" > > do_install() { > install -d ${STAGE_TEMP}