From: Li Zefan <lizf@cn.fujitsu.com>
To: kreijack@inwind.it
Cc: Goffredo Baroncelli <kreijack@libero.it>,
Andreas Philipp <philipp.andreas@gmail.com>,
linux-btrfs@vger.kernel.org, chris.mason@oracle.com
Subject: Re: [PATCH 1/5] Add support for read-only subvolumes.
Date: Tue, 26 Apr 2011 14:06:07 +0800 [thread overview]
Message-ID: <4DB660CF.8050509@cn.fujitsu.com> (raw)
In-Reply-To: <4DB5E8F6.1020807@libero.it>
>> + subvol = argv[optind+1];
>> + dst = argv[optind+2];
>> + struct btrfs_ioctl_vol_args_v2 args;
>
> Does the "standard C" allow to define a variable in the middle in a
> function instead of in the begin ?
> Anyway, even not required, I suggest to fill "args" by zero.
>
> + memset(&args, 0, sizeog(args));
>
It's necessary, otherwise args.unused[4] and args.transid will have
arbitrary value.
next prev parent reply other threads:[~2011-04-26 6:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-25 1:24 Read Only snapshots David Morgado
2011-04-25 12:16 ` Chris Mason
2011-04-25 13:47 ` [PATCH 0/5] Add user-space support for read-only snapshot creation Andreas Philipp
2011-04-25 13:47 ` [PATCH 1/5] Add support for read-only subvolumes Andreas Philipp
2011-04-25 21:34 ` Goffredo Baroncelli
2011-04-25 23:24 ` Chris Mason
2011-04-26 6:06 ` Li Zefan [this message]
2011-04-26 5:48 ` Li Zefan
2011-04-26 5:50 ` Li Zefan
2011-04-25 13:47 ` [PATCH 2/5] Support the new parameters in do_clone(int argc, char** argv) Andreas Philipp
2011-04-25 13:47 ` [PATCH 3/5] Added support for an additional ioctl Andreas Philipp
2011-04-25 13:48 ` [PATCH 4/5] Test the " Andreas Philipp
2011-04-25 13:48 ` [PATCH 5/5] Updated documentation for btrfs subvolume snapshot Andreas Philipp
2011-04-26 5:42 ` [PATCH 0/5] Add user-space support for read-only snapshot creation Li Zefan
-- strict thread matches above, loose matches on Subject: below --
2011-04-13 9:12 Andreas Philipp
2011-04-13 9:12 ` [PATCH 1/5] Add support for read-only subvolumes Andreas Philipp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB660CF.8050509@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=chris.mason@oracle.com \
--cc=kreijack@inwind.it \
--cc=kreijack@libero.it \
--cc=linux-btrfs@vger.kernel.org \
--cc=philipp.andreas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.