From: Hans de Goede <hdegoede@redhat.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Ondrej Zary <linux@rainbow-software.org>,
Joerg Heckenbach <joerg@heckenbach-aw.de>,
Dwaine Garden <dwainegarden@rogers.com>,
linux-media@vger.kernel.org,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usbvision: remove (broken) image format conversion
Date: Tue, 26 Apr 2011 13:11:54 +0200 [thread overview]
Message-ID: <4DB6A87A.2000906@redhat.com> (raw)
In-Reply-To: <201104260832.11150.hverkuil@xs4all.nl>
Hi,
On 04/26/2011 08:32 AM, Hans Verkuil wrote:
> On Monday, April 25, 2011 23:23:17 Ondrej Zary wrote:
>> The YVU420 and YUV422P formats are broken and cause kernel panic on use.
>> (YVU420 does not work and sometimes causes "unable to handle paging request"
>> panic, YUV422P always causes "NULL pointer dereference").
>>
>> As V4L2 spec says that drivers shouldn't do any in-kernel image format
>> conversion, remove it completely (except YUYV).
>
> What really should happen is that the conversion is moved to libv4lconvert.
> I've never had the time to tackle that, but it would improve this driver a
> lot.
>
> Would you perhaps be interested in doing that work?
>
Seconded! I would be more then happy to help with the libv4l part (in the form
of review + merging + advice).
Regards,
Hans
prev parent reply other threads:[~2011-04-26 11:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-25 21:23 [PATCH] usbvision: remove (broken) image format conversion Ondrej Zary
2011-04-26 6:32 ` Hans Verkuil
2011-04-26 8:30 ` Ondrej Zary
2011-04-26 11:54 ` Hans de Goede
2011-04-26 12:33 ` Hans Verkuil
2011-04-26 20:40 ` Ondrej Zary
2011-05-03 10:29 ` Mauro Carvalho Chehab
2011-05-03 16:37 ` Ondrej Zary
2011-06-11 12:13 ` Mauro Carvalho Chehab
2011-06-16 14:28 ` Hans de Goede
2011-04-26 11:11 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB6A87A.2000906@redhat.com \
--to=hdegoede@redhat.com \
--cc=dwainegarden@rogers.com \
--cc=hverkuil@xs4all.nl \
--cc=joerg@heckenbach-aw.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux@rainbow-software.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.