From: Jonathan Cameron <jic23@cam.ac.uk>
To: "Hennerich, Michael" <Michael.Hennerich@analog.com>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Oddities and how to handle them.
Date: Tue, 26 Apr 2011 17:13:33 +0100 [thread overview]
Message-ID: <4DB6EF2D.9090704@cam.ac.uk> (raw)
Hi Michael,
I'm trying to squash the remaining drivers that don't build after
all the changes in iio-onwards. A couple of odd cases have come
up.
ad7291 - has two similar concurrent event measurements on the same temperature channel.
One is almost a windowed average, but not quite. The other based on raw value.
I'm not sure what event code we should generate for them to differentiate between
them. So for now I just have both producing a generic temperature threshold event.
(filtering on data isn't covered by our abi's yet, let alone on event detectors!)
ad7745 - slow capacitance adc. This one actually makes a possibly valid use of the
buffer event codes. It is slow enough that it may make sense to notify userspace
that a new reading is available (90Hz). I'd prefer to see this happen by just allowing
polling on the sysfs attributes though. I have no means to testing this one, and such
a change is a little more invasive than I like to make without hardware!
adt7310 - should be in hwmon as far as I can see.... + it's abusing our interfaces
so I don't like it ;) For now I've squashed the events into basic temp events.
adt7410 - the same.
adt7316 - The fault condition on the external temperature sensor isn't an event that
one should ever see unless something is horribly wrong. I'd be inclined to copy the
hwmon interface for this and do it as an alarm sysfs attribute... I don't think it
belongs in out main event path... For now I've removed it's ability to be reported at all.
ade7758 - Complex driver I'm not that keen on touching without a lot of testing support.
Don't suppose you want to take this one Michael? (*looks hopeful*) At lease blugeoning
it into more or less current interfaces would be a great help. I can do it, but then I
suspect I'll break it in a few exciting ways :(
So all in all, only ad7745 and ade7758 no longer build.
Lots more clean up to be done all over the tree, but I think we are making good progress
in the right direction.
Jonathan
next reply other threads:[~2011-04-26 16:11 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-26 16:13 Jonathan Cameron [this message]
2011-04-27 11:32 ` Oddities and how to handle them Michael Hennerich
2011-04-27 14:42 ` Jonathan Cameron
2011-04-27 15:03 ` Hennerich, Michael
2011-04-27 15:11 ` Jonathan Cameron
2011-04-28 8:36 ` Hennerich, Michael
2011-04-28 9:31 ` Jonathan Cameron
2011-04-28 10:04 ` Michael Hennerich
2011-04-28 10:19 ` Jonathan Cameron
2011-04-28 13:49 ` Guenter Roeck
2011-04-28 13:51 ` Jean Delvare
2011-04-28 14:21 ` Jonathan Cameron
2011-04-28 14:23 ` Guenter Roeck
2011-04-28 14:35 ` Jonathan Cameron
2011-04-28 14:58 ` [Device-drivers-devel] " Michael Hennerich
2011-04-28 15:46 ` Jonathan Cameron
2011-04-29 14:21 ` Michael Hennerich
2011-04-29 15:03 ` Jonathan Cameron
2011-05-02 8:02 ` Michael Hennerich
2011-05-02 14:50 ` Jonathan Cameron
2011-05-03 9:26 ` Michael Hennerich
2011-05-03 9:46 ` Jonathan Cameron
2011-05-03 18:07 ` Jonathan Cameron
2011-05-04 10:56 ` Jonathan Cameron
2011-05-04 18:45 ` Hennerich, Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB6EF2D.9090704@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=Michael.Hennerich@analog.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.