All of lore.kernel.org
 help / color / mirror / Atom feed
From: tanmay.upadhyay@einfochips.com (Tanmay Upadhyay)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Trivial: ARM: pxa168: Bug fix - correct UART DMA channels
Date: Wed, 27 Apr 2011 10:11:26 +0530	[thread overview]
Message-ID: <4DB79E76.1080402@einfochips.com> (raw)
In-Reply-To: <1294121226-3358-1-git-send-email-tanmay.upadhyay@einfochips.com>

On Tuesday 04 January 2011 11:37 AM, Tanmay Upadhyay wrote:
> According to ARMADA_16x_Software_Manual.pdf, DMA channels for
> UART1 are 19, 20 and DMA channels for UART2 are 21, 22.
>
> It's of little significance for now as the PXA UART driver
> doesn't use DMA as of now.
>
> Signed-off-by: Tanmay Upadhyay<tanmay.upadhyay@einfochips.com>
> ---
>   arch/arm/mach-mmp/pxa168.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-mmp/pxa168.c b/arch/arm/mach-mmp/pxa168.c
> index 72b4e76..7564739 100644
> --- a/arch/arm/mach-mmp/pxa168.c
> +++ b/arch/arm/mach-mmp/pxa168.c
> @@ -147,8 +147,8 @@ void pxa168_clear_keypad_wakeup(void)
>   }
>
>   /* on-chip devices */
> -PXA168_DEVICE(uart1, "pxa2xx-uart", 0, UART1, 0xd4017000, 0x30, 21, 22);
> -PXA168_DEVICE(uart2, "pxa2xx-uart", 1, UART2, 0xd4018000, 0x30, 23, 24);
> +PXA168_DEVICE(uart1, "pxa2xx-uart", 0, UART1, 0xd4017000, 0x30, 19, 20);
> +PXA168_DEVICE(uart2, "pxa2xx-uart", 1, UART2, 0xd4018000, 0x30, 21, 22);
>   PXA168_DEVICE(twsi0, "pxa2xx-i2c", 0, TWSI0, 0xd4011000, 0x28);
>   PXA168_DEVICE(twsi1, "pxa2xx-i2c", 1, TWSI1, 0xd4025000, 0x28);
>   PXA168_DEVICE(pwm1, "pxa168-pwm", 0, NONE, 0xd401a000, 0x10);
Is there anything wrong with the patch? Any suggestions please?

Thanks,

Tanmay
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110427/93e8c570/attachment-0001.html>

  reply	other threads:[~2011-04-27  4:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-04  6:07 [PATCH] Trivial: ARM: pxa168: Bug fix - correct UART DMA channels Tanmay Upadhyay
2011-04-27  4:41 ` Tanmay Upadhyay [this message]
2011-04-27  7:28   ` Eric Miao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DB79E76.1080402@einfochips.com \
    --to=tanmay.upadhyay@einfochips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.