All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael J Gruber <git@drmicha.warpmail.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Matej Batic <matej.batic@ge.infn.it>
Subject: Re: [RFC/PATCH] handle_alias: provide GIT_CWD to !alias
Date: Wed, 27 Apr 2011 08:47:11 +0200	[thread overview]
Message-ID: <4DB7BBEF.8010409@drmicha.warpmail.net> (raw)
In-Reply-To: <7v1v0od557.fsf@alter.siamese.dyndns.org>

Junio C Hamano venit, vidit, dixit 27.04.2011 00:22:
> Michael J Gruber <git@drmicha.warpmail.net> writes:
> 
>> Provide an environment variable GIT_CWD which contains the subdirectory
>> from which a !alias was called since these cd to the to level directory
>> before they are executed.
> 
> Isn't this what we usually call "prefix", though?

In code it is called "prefix". But I have to ask: So what? Are you
suggesting GIT_PREFIX? User expectation is probably more tied to CWD,
unless a user knows "rev-parse --show-prefix". I don't care about the
name, and GIT_PREFIX may be more systematic.

A more important point is the prefix-less case (i.e. we are in topdir):
Should GIT_YOUNAMEIT be empty then? I would say yes (just like
"rev-parse --show-prefix"), Duy said no. We need a third vote :)

Also, we may want to scrap this altogether and do !!-aliases instead
(without chdir).

Michael

  reply	other threads:[~2011-04-27  6:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4DA59B27.50506@ge.infn.it>
2011-04-13 13:05 ` [RFC/PATCH] handle_alias: provide GIT_CWD to !alias Michael J Gruber
2011-04-13 13:12   ` Nguyen Thai Ngoc Duy
2011-04-13 13:16     ` Michael J Gruber
2011-04-13 13:24       ` Nguyen Thai Ngoc Duy
2011-04-26 22:22   ` Junio C Hamano
2011-04-27  6:47     ` Michael J Gruber [this message]
2011-04-27  7:40       ` Nguyen Thai Ngoc Duy
2011-04-27  8:10         ` Michael J Gruber
2011-04-27  8:36           ` [PATCH 1/2] t1020: test !alias in subdirectory Michael J Gruber
2011-04-27  8:36             ` [PATCH 2/2] handle_alias: provide GIT_PREFIX to !alias Michael J Gruber
2011-04-27  9:06               ` Nguyen Thai Ngoc Duy
2011-04-27  9:36                 ` Michael J Gruber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DB7BBEF.8010409@drmicha.warpmail.net \
    --to=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=matej.batic@ge.infn.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.