All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] virtio-9p: move 9p files around
Date: Wed, 27 Apr 2011 09:03:56 +0200	[thread overview]
Message-ID: <4DB7BFDC.6050801@web.de> (raw)
In-Reply-To: <1303887233-6668-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 1727 bytes --]

On 2011-04-27 08:53, Aneesh Kumar K.V wrote:
> Now that we start adding more files related to 9pfs
> it make sense to move them to a separate directory
> 
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> ---
>  Makefile.objs                        |   10 +++++++---
>  Makefile.target                      |    6 ++++--
>  configure                            |    2 ++
>  {hw => fsdev}/file-op-9p.h           |    0
>  fsdev/qemu-fsdev.h                   |    2 +-
>  hw/{ => 9pfs}/virtio-9p-debug.c      |    0
>  hw/{ => 9pfs}/virtio-9p-debug.h      |    0
>  hw/{ => 9pfs}/virtio-9p-local.c      |    0
>  hw/{ => 9pfs}/virtio-9p-posix-acl.c  |    2 +-
>  hw/{ => 9pfs}/virtio-9p-xattr-user.c |    2 +-
>  hw/{ => 9pfs}/virtio-9p-xattr.c      |    2 +-
>  hw/{ => 9pfs}/virtio-9p-xattr.h      |    0
>  hw/{ => 9pfs}/virtio-9p.c            |    0
>  hw/{ => 9pfs}/virtio-9p.h            |    2 +-
>  14 files changed, 18 insertions(+), 10 deletions(-)
>  rename {hw => fsdev}/file-op-9p.h (100%)
>  rename hw/{ => 9pfs}/virtio-9p-debug.c (100%)
>  rename hw/{ => 9pfs}/virtio-9p-debug.h (100%)
>  rename hw/{ => 9pfs}/virtio-9p-local.c (100%)
>  rename hw/{ => 9pfs}/virtio-9p-posix-acl.c (99%)
>  rename hw/{ => 9pfs}/virtio-9p-xattr-user.c (98%)
>  rename hw/{ => 9pfs}/virtio-9p-xattr.c (99%)
>  rename hw/{ => 9pfs}/virtio-9p-xattr.h (100%)
>  rename hw/{ => 9pfs}/virtio-9p.c (100%)

That's a good chance to split up this file, move virtio_9p_get_config
into a separate one and build the large virtio-9p.c as part of hwlib
while keeping the new file target-specific. I've some hack for this
lying around, but now that you are already at it...

Thanks,
Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]

  reply	other threads:[~2011-04-27  7:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-27  6:53 [Qemu-devel] [PATCH] virtio-9p: move 9p files around Aneesh Kumar K.V
2011-04-27  7:03 ` Jan Kiszka [this message]
2011-04-27 10:33   ` Aneesh Kumar K.V
2011-04-27 14:55     ` Jan Kiszka
2011-04-27 15:57     ` Venkateswararao Jujjuri
2011-04-27 16:31       ` Aneesh Kumar K.V
2011-04-27 11:46   ` [Qemu-devel] [PATCH 1/3] virtio-9p: Move 9p device registration into virtio-9p.c Aneesh Kumar K.V
2011-04-27 11:46     ` [Qemu-devel] [PATCH 2/3] virtio-9p: move 9p files around Aneesh Kumar K.V
2011-04-27 11:46     ` [Qemu-devel] [PATCH 3/3] virtio-9p: Move device specific code to virtio-9p-device Aneesh Kumar K.V
2011-05-31 21:28     ` [Qemu-devel] [PATCH 1/3] virtio-9p: Move 9p device registration into virtio-9p.c Venkateswararao Jujjuri
2011-06-01  6:49       ` Aneesh Kumar K.V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DB7BFDC.6050801@web.de \
    --to=jan.kiszka@web.de \
    --cc=aliguori@us.ibm.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.