From: Michal Marek <mmarek@suse.cz>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-kbuild@vger.kernel.org,
Roman Zippel <zippel@linux-m68k.org>
Subject: Re: [PATCH] kconfig: Avoid buffer underrun in choice input
Date: Wed, 27 Apr 2011 13:19:52 +0200 [thread overview]
Message-ID: <4DB7FBD8.20109@suse.cz> (raw)
In-Reply-To: <1303580576.4815.3.camel@localhost>
On 23.4.2011 19:42, Ben Hutchings wrote:
> commit 40aee729b350672c2550640622416a855e27938f ('kconfig: fix default
> value for choice input') fixed some cases where kconfig would select
> the wrong option from a choice with a single valid option and thus
> enter an infinite loop.
>
> However, this broke the test for user input of the form 'N?', because
> when kconfig selects the single valid option the input is zero-length
> and the test will read the byte before the input buffer. If this
> happens to contain '?' (as it will in a mips build on Debian unstable
> today) then kconfig again enters an infinite loop.
>
> Signed-off-by: Ben Hutchings<ben@decadent.org.uk>
> Cc: stable@kernel.org [2.6.17+]
> ---
> Roman has failed to respond to this after 5 weeks and one reminder, so
> please take it directly.
I applied this on 8th April, see
http://www.spinics.net/lists/linux-kbuild/msg04431.html. Please check
linux-next before reposting patches next time, now I either have to
rewind the kconfig branch or let Linus merge it with a duplicate commit :-(.
Michal
next prev parent reply other threads:[~2011-04-27 11:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-23 17:42 [PATCH] kconfig: Avoid buffer underrun in choice input Ben Hutchings
2011-04-23 18:04 ` Sam Ravnborg
2011-04-24 4:02 ` Ben Hutchings
2011-04-24 8:39 ` Geert Uytterhoeven
2011-04-27 11:19 ` Michal Marek [this message]
2011-04-27 13:12 ` Ben Hutchings
2011-04-27 17:35 ` Linus Torvalds
-- strict thread matches above, loose matches on Subject: below --
2011-03-19 4:26 Ben Hutchings
2011-04-07 23:41 ` Ben Hutchings
2011-04-08 11:20 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB7FBD8.20109@suse.cz \
--to=mmarek@suse.cz \
--cc=ben@decadent.org.uk \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.