From mboxrd@z Thu Jan 1 00:00:00 1970 From: wg@grandegger.com (Wolfgang Grandegger) Date: Wed, 27 Apr 2011 15:34:04 +0200 Subject: [PATCH v4 1/1] can: add pruss CAN driver. In-Reply-To: <4DB81A12.1000006@grandegger.com> References: <1303474267-6344-1-git-send-email-subhasish@mistralsolutions.com> <1303474267-6344-2-git-send-email-subhasish@mistralsolutions.com> <4DB1A3B7.7060300@pengutronix.de> <4DB5D452.9050500@grandegger.com> <46D523E49EFF489F9B088AE7B9CD7286@subhasishg> <4DB81A12.1000006@grandegger.com> Message-ID: <4DB81B4C.9050404@grandegger.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 04/27/2011 03:28 PM, Wolfgang Grandegger wrote: > On 04/27/2011 03:08 PM, Subhasish Ghosh wrote: >>> >>> - Use just *one* value per sysfs file >> >> SG - I felt adding entry for each mbx_id will clutter the sysfs. >> Is it ok to do that. > > No, see: > > http://lxr.linux.no/#linux+v2.6.38/Documentation/filesystems/sysfs.txt#L56 s/No/Yes/ Sorry for the confusion. Wolfgang. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932516Ab1D0Nbj (ORCPT ); Wed, 27 Apr 2011 09:31:39 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:52522 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932347Ab1D0Nbh (ORCPT ); Wed, 27 Apr 2011 09:31:37 -0400 X-Auth-Info: OEEgO0xeVId/JgtlNo/cbeYDZmI21vg1SUJgDxXRfwY= Message-ID: <4DB81B4C.9050404@grandegger.com> Date: Wed, 27 Apr 2011 15:34:04 +0200 From: Wolfgang Grandegger User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.12) Gecko/20100907 Fedora/3.0.7-1.fc12 Thunderbird/3.0.7 MIME-Version: 1.0 To: Subhasish Ghosh CC: sachi@mistralsolutions.com, davinci-linux-open-source@linux.davincidsp.com, Netdev@vger.kernel.org, nsekhar@ti.com, open list , CAN NETWORK DRIVERS , Marc Kleine-Budde , m-watkins@ti.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 1/1] can: add pruss CAN driver. References: <1303474267-6344-1-git-send-email-subhasish@mistralsolutions.com> <1303474267-6344-2-git-send-email-subhasish@mistralsolutions.com> <4DB1A3B7.7060300@pengutronix.de> <4DB5D452.9050500@grandegger.com> <46D523E49EFF489F9B088AE7B9CD7286@subhasishg> <4DB81A12.1000006@grandegger.com> In-Reply-To: <4DB81A12.1000006@grandegger.com> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/27/2011 03:28 PM, Wolfgang Grandegger wrote: > On 04/27/2011 03:08 PM, Subhasish Ghosh wrote: >>> >>> - Use just *one* value per sysfs file >> >> SG - I felt adding entry for each mbx_id will clutter the sysfs. >> Is it ok to do that. > > No, see: > > http://lxr.linux.no/#linux+v2.6.38/Documentation/filesystems/sysfs.txt#L56 s/No/Yes/ Sorry for the confusion. Wolfgang. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Grandegger Subject: Re: [PATCH v4 1/1] can: add pruss CAN driver. Date: Wed, 27 Apr 2011 15:34:04 +0200 Message-ID: <4DB81B4C.9050404@grandegger.com> References: <1303474267-6344-1-git-send-email-subhasish@mistralsolutions.com> <1303474267-6344-2-git-send-email-subhasish@mistralsolutions.com> <4DB1A3B7.7060300@pengutronix.de> <4DB5D452.9050500@grandegger.com> <46D523E49EFF489F9B088AE7B9CD7286@subhasishg> <4DB81A12.1000006@grandegger.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: sachi-EvXpCiN+lbve9wHmmfpqLFaTQe2KTcn/@public.gmane.org, davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org, Netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, nsekhar-l0cyMroinI0@public.gmane.org, open list , CAN NETWORK DRIVERS , Marc Kleine-Budde , m-watkins-l0cyMroinI0@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Subhasish Ghosh Return-path: In-Reply-To: <4DB81A12.1000006-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org On 04/27/2011 03:28 PM, Wolfgang Grandegger wrote: > On 04/27/2011 03:08 PM, Subhasish Ghosh wrote: >>> >>> - Use just *one* value per sysfs file >> >> SG - I felt adding entry for each mbx_id will clutter the sysfs. >> Is it ok to do that. > > No, see: > > http://lxr.linux.no/#linux+v2.6.38/Documentation/filesystems/sysfs.txt#L56 s/No/Yes/ Sorry for the confusion. Wolfgang.