From: Stephen Boyd <sboyd@codeaurora.org>
To: Sahitya Tummala <stummala@codeaurora.org>
Cc: davidb@codeaurora.org, dwalker@fifo99.com, bryanh@codeaurora.org,
linux-mmc@vger.kernel.org, linux-arm-msm@vger.kernel.org,
san@google.com, Murali Palnati <palnatim@codeaurora.org>
Subject: Re: [PATCH 5/7] mmc: msm_sdcc: Use MCI_INT_MASK0 for PIO interrupts
Date: Wed, 27 Apr 2011 08:52:15 -0700 [thread overview]
Message-ID: <4DB83BAF.2070800@codeaurora.org> (raw)
In-Reply-To: <1303796066-6784-5-git-send-email-stummala@codeaurora.org>
On 04/25/2011 10:34 PM, Sahitya Tummala wrote:
> @@ -659,8 +662,13 @@ msmsdcc_pio_irq(int irq, void *dev_id)
> {
> struct msmsdcc_host *host = dev_id;
> uint32_t status;
> + u32 mci_mask0 = 0;
Is this assignment there to silence an "unused variable" warning? If it
is, please use the uninitialized_var macro. If it isn't please remove
the assignment.
>
> status = msmsdcc_readl(host, MMCISTATUS);
> + mci_mask0 = msmsdcc_readl(host, MMCIMASK0);
> +
> + if (((mci_mask0 & status) & MCI_IRQ_PIO) == 0)
> + return IRQ_NONE;
>
> do {
> unsigned long flags;
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-04-27 15:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-26 5:34 [PATCH 1/7] mmc: msm_sdcc: handle the platform gpio_data not present case Sahitya Tummala
2011-04-26 5:34 ` [PATCH 2/7] mmc: msm_sdcc: Handle error cases in probe Sahitya Tummala
2011-05-02 12:36 ` [PATCH V2 " Sahitya Tummala
2011-04-26 5:34 ` [PATCH 3/7] mmc: msm_sdcc: Enable SDC host->clk only after setting the rate Sahitya Tummala
2011-05-02 12:37 ` [PATCH V2 " Sahitya Tummala
2011-04-26 5:34 ` [PATCH 4/7] msm: mmc: Remove "pio_irq" resource Sahitya Tummala
2011-05-02 12:37 ` [PATCH V2 " Sahitya Tummala
2011-04-26 5:34 ` [PATCH 5/7] mmc: msm_sdcc: Use MCI_INT_MASK0 for PIO interrupts Sahitya Tummala
2011-04-27 15:52 ` Stephen Boyd [this message]
2011-05-02 12:39 ` [PATCH V2 " Sahitya Tummala
2011-04-26 5:34 ` [PATCH 6/7] mmc: msm_sdcc: Change initialization order of busclk_timer in probe Sahitya Tummala
2011-05-02 12:40 ` [PATCH V2 " Sahitya Tummala
2011-04-26 5:34 ` [PATCH 7/7] mmc: msm_sdcc: Handle dma resource not present case Sahitya Tummala
2011-05-02 12:40 ` [PATCH V2 " Sahitya Tummala
2011-05-02 12:33 ` [PATCH V2 1/7] mmc: msm_sdcc: handle the platform gpio_data " Sahitya Tummala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB83BAF.2070800@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=bryanh@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=dwalker@fifo99.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=palnatim@codeaurora.org \
--cc=san@google.com \
--cc=stummala@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.