From: Brian Norris <computersforpeace@gmail.com>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: "Basheer, Mansoor Ahamed" <mansoor.ahamed@ti.com>,
Artem Bityutskiy <Artem.Bityutskiy@nokia.com>,
"Saxena, Parth" <parth.saxena@ti.com>,
linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [RFC] mtd: nand: Fix bad block identification issue
Date: Wed, 27 Apr 2011 17:45:45 -0700 [thread overview]
Message-ID: <4DB8B8B9.4050604@gmail.com> (raw)
In-Reply-To: <BANLkTi=sq5am1HKeOfYTmYHUm96O08N-jw@mail.gmail.com>
Hi,
On 4/27/2011 8:45 AM, Grazvydas Ignotas wrote:
> Brian,
>
> did you really intend to remove badblockbits? Maybe it should go back
> to nand_base.c?
No, I had no intention of the sorts! It surely should not have been
removed in the first place. I will "ack" a patch to revert it, or next
time I'm at my work machine I'll write one myself.
As a defense for myself...I think I was relatively new to git + kernel
hacking at the time I sent this patch. Sorry for the messup.
> On Wed, Apr 27, 2011 at 3:09 PM, Saxena, Parth <parth.saxena@ti.com> wrote:
>> Commit e0b58d0 ("mtd: nand: add ->badblockbits for minimum number
>> of set bits in bad block byte") by Maxim Levitsky added
>> badblockbits to nand_chip to specify minimum number of set bits
>> in bad block byte. The patch initialized badblockbits to 8 in
>> nand_base.c, but later the initialization line got removed by commit
>> c7b28e2("mtd: nand: refactor BB marker detection"). After this all
>> NAND drivers with NAND_SKIP_BBTSCAN are forced to initialize it to 8.
>> Otherwise bad block identification will fail.
Brian
WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <computersforpeace@gmail.com>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org,
"Basheer, Mansoor Ahamed" <mansoor.ahamed@ti.com>,
"Saxena, Parth" <parth.saxena@ti.com>,
Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Subject: Re: [RFC] mtd: nand: Fix bad block identification issue
Date: Wed, 27 Apr 2011 17:45:45 -0700 [thread overview]
Message-ID: <4DB8B8B9.4050604@gmail.com> (raw)
In-Reply-To: <BANLkTi=sq5am1HKeOfYTmYHUm96O08N-jw@mail.gmail.com>
Hi,
On 4/27/2011 8:45 AM, Grazvydas Ignotas wrote:
> Brian,
>
> did you really intend to remove badblockbits? Maybe it should go back
> to nand_base.c?
No, I had no intention of the sorts! It surely should not have been
removed in the first place. I will "ack" a patch to revert it, or next
time I'm at my work machine I'll write one myself.
As a defense for myself...I think I was relatively new to git + kernel
hacking at the time I sent this patch. Sorry for the messup.
> On Wed, Apr 27, 2011 at 3:09 PM, Saxena, Parth <parth.saxena@ti.com> wrote:
>> Commit e0b58d0 ("mtd: nand: add ->badblockbits for minimum number
>> of set bits in bad block byte") by Maxim Levitsky added
>> badblockbits to nand_chip to specify minimum number of set bits
>> in bad block byte. The patch initialized badblockbits to 8 in
>> nand_base.c, but later the initialization line got removed by commit
>> c7b28e2("mtd: nand: refactor BB marker detection"). After this all
>> NAND drivers with NAND_SKIP_BBTSCAN are forced to initialize it to 8.
>> Otherwise bad block identification will fail.
Brian
next prev parent reply other threads:[~2011-04-28 0:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 12:09 [RFC] mtd: nand: Fix bad block identification issue Saxena, Parth
2011-04-27 12:09 ` Saxena, Parth
2011-04-27 15:45 ` Grazvydas Ignotas
2011-04-27 15:45 ` Grazvydas Ignotas
2011-04-28 0:45 ` Brian Norris [this message]
2011-04-28 0:45 ` Brian Norris
2011-04-28 17:30 ` Artem Bityutskiy
2011-04-28 17:30 ` Artem Bityutskiy
2011-04-29 13:12 ` Artem Bityutskiy
2011-04-29 13:12 ` Artem Bityutskiy
2011-04-29 14:22 ` Saxena, Parth
2011-04-29 14:22 ` Saxena, Parth
2011-04-29 17:44 ` Artem Bityutskiy
2011-04-29 17:44 ` Artem Bityutskiy
2011-04-29 18:03 ` Brian Norris
2011-04-29 18:03 ` Brian Norris
2011-04-29 18:05 ` Artem Bityutskiy
2011-04-29 18:05 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB8B8B9.4050604@gmail.com \
--to=computersforpeace@gmail.com \
--cc=Artem.Bityutskiy@nokia.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mansoor.ahamed@ti.com \
--cc=notasas@gmail.com \
--cc=parth.saxena@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.