Re: [PATCH 1/5] USB: gadget: Fix unused variable warning in ci13xxx_udc

[Pavan Kondeti <pkondeti@codeaurora.org>]

On 4/28/2011 3:31 PM, Michal Nazarewicz wrote:
> On Thu, 28 Apr 2011 09:58:17 +0200, Pavankumar Kondeti  
> <pkondeti@codeaurora.org> wrote:
> 
>> Signed-off-by: Pavankumar Kondeti <pkondeti@codeaurora.org>
>> ---
>>  drivers/usb/gadget/ci13xxx_udc.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/ci13xxx_udc.c  
>> b/drivers/usb/gadget/ci13xxx_udc.c
>> index e09178b..6a9ad59 100644
>> --- a/drivers/usb/gadget/ci13xxx_udc.c
>> +++ b/drivers/usb/gadget/ci13xxx_udc.c
>> @@ -1843,7 +1843,7 @@ __releases(mEp->lock)
>>  __acquires(mEp->lock)
>>  {
>>  	struct ci13xxx_req *mReq, *mReqTemp;
>> -	int retval;
>> +	int uninitialized_var(retval);
>> 	trace("%p", mEp);
> 
> Could we instead set it to 0?
>

would it matter anyway? we return -EINVAL if the queue is empty.
Otherwise we assign retval = _hardware_dequeue().

> Also, it seems this function has a bug where it compares retval
> with EBUSY instead of -EBUSY:
> 
> 	if (retval == EBUSY)
> 		retval = 0;
> 
> Just saying in case anyone wants to take care of it.
> 

Thanks for pointing this out. I will send out a patch to fix this.

As of now isr_tr_complete_low() return value is simply ignored for
non-control endpoints. We never hit this case for control endpoint.

-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.