From: Sakari Ailus <sakari.ailus@maxwell.research.nokia.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Yordan Kamenov <ykamenov@mm-sol.com>, linux-media@vger.kernel.org
Subject: Re: [PATCH 1/1 v3] libv4l: Add plugin support to libv4l
Date: Thu, 28 Apr 2011 17:18:13 +0300 [thread overview]
Message-ID: <4DB97725.2070501@maxwell.research.nokia.com> (raw)
In-Reply-To: <4DB961A3.70000@redhat.com>
Hans de Goede wrote:
> Hi,
Hi Hans, Yordan,
> First of all my apologies for taking so long to get around to
> reviewing this.
>
> Over all it looks good, I've put some small remarks inline, if
> you fix these I can merge this. I wonder though, given the recent
> limbo around Nokia's change of focus, if there are any plans to
> actually move forward with a plugin using this... ?
Yes, there are. That hasn't changed a bit.
> The reason I'm asking is that adding the plugin framework if nothing
> is going to use it seems a bit senseless.
I agree with that. I also hope others would find the plugin framework
useful as well. :-)
A minor comment on the patch itself: there are a few checkpatch.pl
warnings from it, mostly lines over 80 characters, but also others.
Cheers,
--
Sakari Ailus
sakari.ailus@maxwell.research.nokia.com
next prev parent reply other threads:[~2011-04-28 14:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-14 11:02 [PATCH 0/1 v3] libv4l: Add plugin support Yordan Kamenov
2011-02-14 11:02 ` [PATCH 1/1 v3] libv4l: Add plugin support to libv4l Yordan Kamenov
2011-04-28 12:46 ` Hans de Goede
2011-04-28 14:18 ` Sakari Ailus [this message]
2011-04-28 14:30 ` Hans Verkuil
2011-04-29 8:55 ` Yordan Kamenov
2011-04-29 12:08 ` Hans de Goede
2011-03-10 13:46 ` [PATCH 0/1 v3] libv4l: Add plugin support Yordan Kamenov
2011-03-10 19:35 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB97725.2070501@maxwell.research.nokia.com \
--to=sakari.ailus@maxwell.research.nokia.com \
--cc=hdegoede@redhat.com \
--cc=linux-media@vger.kernel.org \
--cc=ykamenov@mm-sol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.