From: Stefan Weil <weil@mail.berlios.de>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCHv2] ide/atapi: fix set but unused
Date: Thu, 28 Apr 2011 16:46:53 +0200 [thread overview]
Message-ID: <4DB97DDD.2010908@mail.berlios.de> (raw)
In-Reply-To: <1303997679-8885-1-git-send-email-alevy@redhat.com>
Am 28.04.2011 15:34, schrieb Alon Levy:
> Signed-off-by: Alon Levy<alevy@redhat.com>
> ---
> hw/ide/atapi.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c
> index 690a0ab..0073c8d 100644
> --- a/hw/ide/atapi.c
> +++ b/hw/ide/atapi.c
> @@ -1080,17 +1080,15 @@ static const struct {
>
> void ide_atapi_cmd(IDEState *s)
> {
> - const uint8_t *packet;
> uint8_t *buf;
>
> - packet = s->io_buffer;
> buf = s->io_buffer;
> #ifdef DEBUG_IDE_ATAPI
> {
> int i;
> printf("ATAPI limit=0x%x packet:", s->lcyl | (s->hcyl<< 8));
> for(i = 0; i< ATAPI_PACKET_SIZE; i++) {
> - printf(" %02x", packet[i]);
> + printf(" %02x", buf[i]);
> }
> printf("\n");
> }
>
Acked-by: Stefan Weil <weil@mail.berlios.de>
next prev parent reply other threads:[~2011-04-28 14:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 8:07 [Qemu-devel] [PATCH] ide/atapi: fix set but unused Alon Levy
2011-04-28 12:07 ` Paolo Bonzini
2011-04-28 12:16 ` Stefan Weil
2011-04-28 12:35 ` Paolo Bonzini
2011-04-28 13:34 ` [Qemu-devel] [PATCHv2] " Alon Levy
2011-04-28 14:46 ` Stefan Weil [this message]
2011-04-29 10:58 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB97DDD.2010908@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=alevy@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.