From: Richard Henderson <rth@twiddle.net>
To: Alexander Graf <agraf@suse.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
aik@ozlabs.ru, Joerg.Rodel@amd.com, qemu-devel@nongnu.org,
eduard.munteanu@linux360.ro,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] Supporting emulation of IOMMUs
Date: Thu, 28 Apr 2011 14:57:14 -0700 [thread overview]
Message-ID: <4DB9E2BA.7050602@twiddle.net> (raw)
In-Reply-To: <67FBBBAD-991F-48D8-901F-490C17B9DBC2@suse.de>
On 04/21/2011 02:39 AM, Alexander Graf wrote:
> How exactly is this going to be used? Also, in the end I think that
> most devices should just go through a PCI specific interface that
> then calls the DMA helpers:
>
> pci_memory_rw(PCIDevice *d, ...)
>
> even if it's only as simple as calling
>
> dma_memory_rw(d->iommu, ...)
I've had a read through the patches posted in January. It all does
seem relatively sane. At least, I can readily see how I would apply
these interfaces to my Alpha port without trouble.
I'll agree with Alex though that the raw dma_memory_rw functions
should not be exposed to the drivers for any given bus. They should
always go through {pci,isa}_memory_rw. And these should almost
certainly be inline functions that just pass on &device->bus.mmu.
r~
next prev parent reply other threads:[~2011-04-28 22:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 7:03 [Qemu-devel] Supporting emulation of IOMMUs David Gibson
2011-04-21 9:39 ` Alexander Graf
2011-04-28 21:57 ` Richard Henderson [this message]
2011-04-29 14:27 ` Richard Henderson
2011-05-09 3:28 ` David Gibson
2011-05-09 2:06 ` David Gibson
2011-05-09 2:05 ` David Gibson
2011-04-21 18:47 ` Eduard - Gabriel Munteanu
2011-05-10 1:44 ` David Gibson
2011-05-14 15:27 ` Eduard - Gabriel Munteanu
2011-05-14 23:16 ` Benjamin Herrenschmidt
2011-04-26 15:58 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB9E2BA.7050602@twiddle.net \
--to=rth@twiddle.net \
--cc=Joerg.Rodel@amd.com \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=aliguori@us.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=eduard.munteanu@linux360.ro \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.