All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Steffen Barszus <steffenbpunkt@googlemail.com>
Cc: linux-media@vger.kernel.org, Manu Abraham <abraham.manu@gmail.com>
Subject: Re: patches missing in git ? - TT S2 1600
Date: Fri, 29 Apr 2011 10:48:15 -0300	[thread overview]
Message-ID: <4DBAC19F.7010003@redhat.com> (raw)
In-Reply-To: <20110306142020.7fe695ca@grobi>

Em 06-03-2011 10:20, Steffen Barszus escreveu:
> I have one patch lying around which will fix a kernel oops if more than
> one TT S2 1600 is build into the same computer. 

I think that the bug with two TT S2 devices at the same computer were fixed,
but I don't remember what were the adopted solution.

I think that the change were inside tuner_sleep() callback, where tuner_priv
is actually used.

So, as far as I know, this patch is obsolete. I'll mark it as rejected on
patchwork. Please test it without this patch and the latest tree, pinging
us if the error is still there.

> 
> It still applies and compiles - does someone know if this has been
> obsoleted by another patch or if that means it is still missing ? 
> 
> Thanks !
> 
> Kind Regards 
> 
> Steffen
> 
> diff -r 7c0b887911cf linux/drivers/media/dvb/frontends/stv090x.c
> --- a/linux/drivers/media/dvb/frontends/stv090x.c	Mon Apr 05 22:56:43 2010 -0400
> +++ b/linux/drivers/media/dvb/frontends/stv090x.c	Sun Apr 11 13:46:43 2010 +0200
> @@ -4664,7 +4664,7 @@ 
>  	if (stv090x_i2c_gate_ctrl(state, 1) < 0)
>  		goto err;
>  
> -	if (state->config->tuner_sleep) {
> +	if (fe->tuner_priv && state->config->tuner_sleep) {
>  		if (state->config->tuner_sleep(fe) < 0)
>  			goto err_gateoff;
>  	}
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


  reply	other threads:[~2011-04-29 13:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-06 13:20 patches missing in git ? - TT S2 1600 Steffen Barszus
2011-04-29 13:48 ` Mauro Carvalho Chehab [this message]
2011-09-02 10:59   ` Steffen Barszus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DBAC19F.7010003@redhat.com \
    --to=mchehab@redhat.com \
    --cc=abraham.manu@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=steffenbpunkt@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.