All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Stone <jistone@redhat.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH] blame: Improve parsing for emails with spaces
Date: Fri, 29 Apr 2011 11:17:48 -0700	[thread overview]
Message-ID: <4DBB00CC.3030400@redhat.com> (raw)
In-Reply-To: <7vvcxxvsz4.fsf@alter.siamese.dyndns.org>

On 04/29/2011 10:59 AM, Junio C Hamano wrote:
> It would be an entirely different issue if the command barfed and refused
> to blame the file.

Yeah - the command doesn't fail outright.  Anything that builds on
blame/annotate would get bad data, but for me it's more of a formatting
issue.  In my actual bad commit, the author's "name <broken email" takes
up 61 characters, making the whole blame output tediously wide.

Thanks for taking the patch.

Josh

  parent reply	other threads:[~2011-04-29 18:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-21 22:07 [PATCH] blame: Improve parsing for emails with spaces Josh Stone
2011-04-29 13:11 ` Jeff King
2011-04-29 17:59   ` Junio C Hamano
2011-04-29 18:09     ` Junio C Hamano
2011-04-29 18:17     ` Josh Stone [this message]
2011-04-29 19:13     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DBB00CC.3030400@redhat.com \
    --to=jistone@redhat.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.