All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org,
	"Rafał Miłecki" <zajec5@gmail.com>,
	"Michael Buesch" <mb@bu3sch.de>
Subject: Re: [PATCH] b43: avoid uninitialized variable warnings in phy_n
Date: Fri, 29 Apr 2011 14:21:43 -0500	[thread overview]
Message-ID: <4DBB0FC7.8040809@lwfinger.net> (raw)
In-Reply-To: <1304103559-28415-1-git-send-email-linville@tuxdriver.com>

On 04/29/2011 01:59 PM, John W. Linville wrote:
>    CC [M]  drivers/net/wireless/b43/phy_n.o
> drivers/net/wireless/b43/phy_n.c: In function ‘b43_nphy_set_channel’:
> drivers/net/wireless/b43/phy_n.c:3848:47: warning: ‘tabent_r2’ may be used uninitialized in this function
> drivers/net/wireless/b43/phy_n.c:3849:47: warning: ‘tabent_r3’ may be used uninitialized in this function
> drivers/net/wireless/b43/phy_n.c: In function ‘b43_nphy_poll_rssi.clone.14’:
> drivers/net/wireless/b43/phy_n.c:2270:6: warning: ‘save_regs_phy$7’ may be used uninitialized in this function
> drivers/net/wireless/b43/phy_n.c:2270:6: warning: ‘save_regs_phy$8’ may be used uninitialized in this function
>
> FWIW, the usage of these variables is goverened by checks that match
> their initializations.  So, I think these are actually false warnings.
> Still, I would rather avoid the warning SPAM...
>
> Signed-off-by: John W. Linville<linville@tuxdriver.com>
> ---
>   drivers/net/wireless/b43/phy_n.c |    7 +++++--
>   1 files changed, 5 insertions(+), 2 deletions(-)
>

If you s/goverened/governed/ in the commit message, then ACK.

For my info, what compiler version and architecture shows these warnings? I 
don't see them with gcc v4.5.1 on x86_64.

Larry

  reply	other threads:[~2011-04-29 19:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-29 18:59 [PATCH] b43: avoid uninitialized variable warnings in phy_n John W. Linville
2011-04-29 19:21 ` Larry Finger [this message]
2011-04-29 19:43   ` John W. Linville
2011-04-30 17:27     ` Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DBB0FC7.8040809@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mb@bu3sch.de \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.