From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Patrick Boettcher <pboettcher@kernellabs.com>
Cc: Florian Mickler <florian@mickler.org>,
oliver@neukum.org, linux-kernel@vger.kernel.org,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [media] dib0700: get rid of on-stack dma buffers
Date: Fri, 29 Apr 2011 18:32:34 -0300 [thread overview]
Message-ID: <4DBB2E72.3030800@infradead.org> (raw)
In-Reply-To: <alpine.LRH.2.00.1104040940000.31158@pub1.ifh.de>
Em 04-04-2011 04:42, Patrick Boettcher escreveu:
> Hi Florian,
>
> On Sun, 3 Apr 2011, Florian Mickler wrote:
>
>> Hi,
>>
>> since I got no reaction[1] on the vp702x driver, I proceed with the
>> dib0700.
>>
>> There are multiple drivers in drivers/media/dvb/dvb-usb/ which use
>> usb_control_msg to perform dma to stack-allocated buffers. This is a bad idea
>> because of cache-coherency issues and on some platforms the stack is mapped
>> virtually and also lib/dma-debug.c warn's about it at runtime.
>>
>> Patches to ec168, ce6230, au6610 and lmedm04 were already tested and reviewed
>> and submitted for inclusion [2]. Patches to a800, vp7045, friio, dw2102, m920x
>> and opera1 are still waiting for for review and testing [3].
>>
>> This patch to dib0700 is a fix for a warning seen and reported by Zdenek
>> Kabalec in Bug #15977 [4].
>>
>> Florian Mickler (2):
>> [media] dib0700: get rid of on-stack dma buffers
>
> For this one we implemented an alternative. See here:
>
> http://git.linuxtv.org/pb/media_tree.git?a=commit;h=16b54de2d8b46e48c5c8bdf9b350eac04e8f6b46
>
> which I pushed, but obviously forgot to send the pull-request.
>
> This is done now.
And I obviously forgot to pick ;) Ok, I'm applying Oliver Grenie's version and
marking Florian's version as superseded at patchwork.
> For the second patch I will incorperate it as soon as I find the time.
As it is a trivial fix, I'll be picking it directly.
>
> best regards,
> --
>
> Patrick
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-04-29 21:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-03 17:23 [media] dib0700: get rid of on-stack dma buffers Florian Mickler
2011-04-03 17:23 ` [PATCH 1/2] " Florian Mickler
2011-04-03 17:23 ` [PATCH 2/2] [media] dib0700: remove unused variable Florian Mickler
2011-04-04 7:42 ` [media] dib0700: get rid of on-stack dma buffers Patrick Boettcher
2011-04-04 16:20 ` Florian Mickler
2011-04-04 19:34 ` Florian Mickler
2011-04-29 21:32 ` Mauro Carvalho Chehab [this message]
2011-04-30 9:46 ` Florian Mickler
2011-04-30 12:50 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DBB2E72.3030800@infradead.org \
--to=mchehab@infradead.org \
--cc=florian@mickler.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=pboettcher@kernellabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.