From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Cc: Koen Kooi <koen@dominion.thruhere.net>,
Martin Jansa <martin.jansa@gmail.com>
Subject: Re: [PATCH] git: use DESTDIR=$D instead prefixing all variables by $D
Date: Fri, 29 Apr 2011 15:09:09 -0700 [thread overview]
Message-ID: <4DBB3705.3060503@linux.intel.com> (raw)
In-Reply-To: <1304072026-31760-1-git-send-email-koen@dominion.thruhere.net>
On 04/29/2011 03:13 AM, Koen Kooi wrote:
> From: Martin Jansa<martin.jansa@gmail.com>
>
> * with git-native and rm_work enabled I've noticed git fetcher errors like:
> warning: templates not found /OE/shr-core/tmp/work/x86_64-linux/git-native-1.7.3.4-r0/image/OE/shr-core/tmp/sysroots/x86_64-linux/usr/share/git-core/templates
> fatal: Unable to find remote helper for 'http'
> for every recipe using http:// for git repo
> * after this change template_dir points to
> /OE/shr-core/tmp/sysroots/x86_64-linux/usr/share/git-core/templates
> without that workdir prefix
> * haven't tested target recipe, but I guess it needs different fix or
> maybe it worked before and gets broken by this change (that's why this
> is just RFC)
>
Is this still just an RFC or has it been tested on the target?
Sau!
> Signed-off-by: Martin Jansa<Martin.Jansa@gmail.com>
> Signed-off-by: Koen Kooi<koen@dominion.thruhere.net>
> ---
> meta/recipes-devtools/git/git.inc | 4 ++--
> meta/recipes-devtools/git/git_1.7.4.3.bb | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-devtools/git/git.inc b/meta/recipes-devtools/git/git.inc
> index e1d1c71..843a1d3 100644
> --- a/meta/recipes-devtools/git/git.inc
> +++ b/meta/recipes-devtools/git/git.inc
> @@ -14,8 +14,8 @@ EXTRA_OECONF = "--with-perl=${STAGING_BINDIR_NATIVE}/perl --without-tcltk"
> inherit autotools
>
> do_install () {
> - oe_runmake install prefix=${D} bindir=${D}${bindir} gitexecdir=${D}${gitexecdir} \
> - template_dir=${D}${datadir}/git-core/templates \
> + oe_runmake install DESTDIR="${D}" bindir=${bindir} gitexecdir=${gitexecdir} \
> + template_dir=${datadir}/git-core/templates \
> GIT_PYTHON_DIR=${D}${datadir}/git-core/python
> }
>
> diff --git a/meta/recipes-devtools/git/git_1.7.4.3.bb b/meta/recipes-devtools/git/git_1.7.4.3.bb
> index 603d2fd..2ff1ed5 100644
> --- a/meta/recipes-devtools/git/git_1.7.4.3.bb
> +++ b/meta/recipes-devtools/git/git_1.7.4.3.bb
> @@ -1,6 +1,6 @@
> require git.inc
>
> -PR = "r0"
> +PR = "r1"
>
> EXTRA_OECONF += "ac_cv_snprintf_returns_bogus=no ac_cv_c_c99_format=yes \
> ac_cv_fread_reads_directories=${ac_cv_fread_reads_directories=yes} \
next prev parent reply other threads:[~2011-04-29 22:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-29 10:13 [PATCH] git: use DESTDIR=$D instead prefixing all variables by $D Koen Kooi
2011-04-29 22:09 ` Saul Wold [this message]
2011-04-30 8:01 ` Koen Kooi
2011-05-02 23:11 ` Khem Raj
2011-05-03 18:36 ` Koen Kooi
2011-05-03 19:07 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DBB3705.3060503@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=koen@dominion.thruhere.net \
--cc=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.