From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QG3O0-0005Se-ML for qemu-devel@nongnu.org; Sat, 30 Apr 2011 02:10:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QG3Nz-0007v6-Ld for qemu-devel@nongnu.org; Sat, 30 Apr 2011 02:10:36 -0400 Received: from mail-pw0-f45.google.com ([209.85.160.45]:46939) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QFwL9-00074d-Nq for qemu-devel@nongnu.org; Fri, 29 Apr 2011 18:39:11 -0400 Received: by pwi6 with SMTP id 6so2463704pwi.4 for ; Fri, 29 Apr 2011 15:39:10 -0700 (PDT) Sender: Richard Henderson Message-ID: <4DBB3E0C.9000004@twiddle.net> Date: Fri, 29 Apr 2011 15:39:08 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1304023875-25040-1-git-send-email-rth@twiddle.net> <1304023875-25040-3-git-send-email-rth@twiddle.net> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 02/33] gdbserver: Don't deliver TIMER interrupts when SSTEP_NOIRQ either. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org On 04/29/2011 01:53 PM, Blue Swirl wrote: >> + CPU_INTERRUPT_TIMER | > > Grepping for CPU_INTERRUPT_TIMER shows that the flag isn't ever set, > only cleared or checked. How > about removing the flag instead? Certainly Sparc and MIPS shouldn't check it if they don't set it. For Alpha, I do want to easily discriminate between device, timer, and inter-processor interrupts. I'm currently (ab)using the i386 CPU_INTERRUPT_SMI name for the IPI; I could abuse, say, FIQ for my timer bit, but it seems nicer to simply keep the TIMER name. r~