Re: [PATCH 1/1] qemuimagetest: Enable toolchain automation tests in qemuimagetest

[Saul Wold <saul.wold@intel.com>]

On 04/28/2011 11:19 PM, Xu, Jiajun wrote:
>>> diff --git a/meta/classes/populate_sdk.bbclass
>>> b/meta/classes/populate_sdk.bbclass
>>> index 413eb52..70670ba 100644
>>> --- a/meta/classes/populate_sdk.bbclass
>>> +++ b/meta/classes/populate_sdk.bbclass
>>> @@ -1,6 +1,9 @@
>>>    inherit meta toolchain-scripts
>>>    inherit populate_sdk_${IMAGE_PKGTYPE}
>>> +IMAGETEST ?= "dummy"
>>> +inherit imagetest-${IMAGETEST}
>>> +
>> Why does this need to be added here?
>>
>> I understand that when IMAGETEST is set to qemu in the local.conf file
>> that it will be pulled in, but why to populate_sdk?
>>
>
> Hi Saul,
> Do you mean IMAGETEST should not be inherited in populate_sdk? Do you think it OK to inherit IMAGETEST in meta-toolchain.bb?
>
Jiajun,

No, I am trying to understand where the connection of having the inherit 
here at all?  I don't see where the imagetest is used, maybe I am not 
seeing the whole picture currectly.

Sau!

> diff --git a/meta/recipes-core/meta/meta-toolchain.bb b/meta/recipes-core/meta/meta-toolchain.bb
> index 94c8a91..ab98bf9 100644
> --- a/meta/recipes-core/meta/meta-toolchain.bb
> +++ b/meta/recipes-core/meta/meta-toolchain.bb
> @@ -6,6 +6,7 @@ PR = "r4"
>   LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
>                       file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
>
> -inherit populate_sdk
> +IMAGETEST ?= "dummy"
> +inherit populate_sdk imagetest-${IMAGETEST}
>
>
>> Sau!
>
> Best Regards,
> Jiajun
>
>
>