From: Jan Kiszka <jan.kiszka@domain.hid>
To: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
Cc: "xenomai@xenomai.org" <xenomai@xenomai.org>
Subject: Re: [Xenomai-core] [Xenomai-git] Jan Kiszka : x86: Fix return type of DO_SYSCALL_INNER macro
Date: Sat, 30 Apr 2011 12:47:33 +0200 [thread overview]
Message-ID: <4DBBE8C5.9080508@domain.hid> (raw)
In-Reply-To: <4DBB05A6.10704@domain.hid>
[-- Attachment #1: Type: text/plain, Size: 981 bytes --]
On 2011-04-29 20:38, Gilles Chanteperdrix wrote:
> GIT version control wrote:
>> Module: xenomai-jki
>> Branch: for-upstream
>> Commit: 852c130d16410a597536c39d06b6abd1c9c6c822
>> URL: http://git.xenomai.org/?p=xenomai-jki.git;a=commit;h=852c130d16410a597536c39d06b6abd1c9c6c822
>>
>> Author: Jan Kiszka <jan.kiszka@domain.hid>
>> Date: Fri Apr 29 14:12:13 2011 +0200
>>
>> x86: Fix return type of DO_SYSCALL_INNER macro
>>
>> gcc will complain about 'conversion to ‘int’ from ‘long int’ may alter
>> its value' with -Wconversion as DO_SYSCALL treats the return value of
>> DO_SYSCALL_INNER as int. Align DO_SYSCALL_INNER to its user.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@domain.hid>
>
> Should not it be aligned the other way around? Using longs everywhere?
> In case a syscall returns a pointer?
Maybe. But let's do this when we have a use case. Lots of arch macros,
inline functions, and core code would have to be touched.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2011-04-30 10:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1QFme6-0000lI-Pf@domain.hid>
2011-04-29 18:38 ` [Xenomai-core] [Xenomai-git] Jan Kiszka : x86: Fix return type of DO_SYSCALL_INNER macro Gilles Chanteperdrix
2011-04-30 10:47 ` Jan Kiszka [this message]
2011-04-30 11:05 ` Gilles Chanteperdrix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DBBE8C5.9080508@domain.hid \
--to=jan.kiszka@domain.hid \
--cc=gilles.chanteperdrix@xenomai.org \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.