From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH V4 2/5] USB: OTG: msm: vote for dayatona fabric clock Date: Tue, 03 May 2011 15:14:34 +0400 Message-ID: <4DBFE39A.4010804@ru.mvista.com> References: <1303977693-18389-1-git-send-email-pkondeti@codeaurora.org> <1304399633-16120-1-git-send-email-pkondeti@codeaurora.org> <1304399633-16120-3-git-send-email-pkondeti@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1304399633-16120-3-git-send-email-pkondeti-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Pavankumar Kondeti Cc: greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, davidb-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org, Anji jonnala List-Id: linux-arm-msm@vger.kernel.org Hello. On 03-05-2011 9:13, Pavankumar Kondeti wrote: > From: Anji jonnala > HSUSB core clock is derived from daytona fabric clock and for > HSUSB operational require minimum core clock at 55MHz. Since, HSUSB > cannot tolerate daytona fabric clock change in the middle of HSUSB > operational, vote for maximum Daytona fabric clock > while usb is operational > Signed-off-by: Anji jonnala > Signed-off-by: Pavankumar Kondeti [...] > diff --git a/drivers/usb/otg/msm_otg.c b/drivers/usb/otg/msm_otg.c > index 2965986..cfbb606 100644 > --- a/drivers/usb/otg/msm_otg.c > +++ b/drivers/usb/otg/msm_otg.c [...] > @@ -954,7 +979,11 @@ free_regs: > put_core_clk: > if (motg->core_clk) > clk_put(motg->core_clk); > - clk_put(motg->pclk); Is it really correct to remove this line? > +put_pclk_src: > + if (!IS_ERR(motg->pclk_src)) { > + clk_disable(motg->pclk_src); > + clk_put(motg->pclk_src); > + } > put_clk: > clk_put(motg->clk); > put_phy_reset_clk: WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html