From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 6/6] KVM: PPC: Add kvm headers to headers_install Date: Tue, 03 May 2011 17:10:04 +0200 Message-ID: <4DC01ACC.4020700@siemens.com> References: <1304426221-23178-1-git-send-email-agraf@suse.de> <1304426221-23178-7-git-send-email-agraf@suse.de> <4DC00F49.9000801@siemens.com> <4B55CF66-84B0-4B34-9D1E-8E71E31462A1@suse.de> <4DC014E0.6030706@siemens.com> <00EA08FF-5902-4D50-87A9-6D2FE8565657@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: KVM devel mailing list To: Alexander Graf Return-path: Received: from david.siemens.de ([192.35.17.14]:29340 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752460Ab1ECPKG (ORCPT ); Tue, 3 May 2011 11:10:06 -0400 In-Reply-To: <00EA08FF-5902-4D50-87A9-6D2FE8565657@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On 2011-05-03 17:04, Alexander Graf wrote: > > On 03.05.2011, at 16:44, Jan Kiszka wrote: > >> On 2011-05-03 16:36, Alexander Graf wrote: >>> >>> On 03.05.2011, at 16:20, Jan Kiszka wrote: >>> >>>> On 2011-05-03 14:37, Alexander Graf wrote: >>>>> When running "make headers_install", we don't install kvm headers on >>>>> PPC. This confuses Qemu, as it really wants to include kernel headers >>>>> to know the ioctl structs. >>>>> >>>>> So let's add the arch/powerpc/include/asm headers that are important >>>>> for KVM to the headers_install list. >>>>> >>>>> Signed-off-by: Alexander Graf >>>>> --- >>>>> arch/powerpc/include/asm/Kbuild | 2 ++ >>>>> 1 files changed, 2 insertions(+), 0 deletions(-) >>>>> >>>>> diff --git a/arch/powerpc/include/asm/Kbuild b/arch/powerpc/include/asm/Kbuild >>>>> index d51df17..568b000 100644 >>>>> --- a/arch/powerpc/include/asm/Kbuild >>>>> +++ b/arch/powerpc/include/asm/Kbuild >>>>> @@ -34,3 +34,5 @@ header-y += termios.h >>>>> header-y += types.h >>>>> header-y += ucontext.h >>>>> header-y += unistd.h >>>>> +header-y += kvm.h >>>>> +header-y += kvm_para.h >>>> >>>> Weird, just worked for me with current kvm master without your patch. >>> >>> Oh? You did do make headers_install and it did push the correct headers to usr? >> >> I strongly suspect. It's all documented in my header patch. > > Your header patch manually copies the respective files, so you're not using that code path there? > I'm copying from the output dir auf headers_install (INSTALL_HDR_PATH). What step does this patch target at? Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux