From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [Qemu-devel] [RFC][PATCH] Import Linux headers for KVM and vhost Date: Tue, 03 May 2011 17:32:59 +0200 Message-ID: <4DC0202B.5020407@siemens.com> References: <4DC00BB1.7000008@siemens.com> <20110503151234.GA13171@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: qemu-devel , Anthony Liguori , Marcelo Tosatti , Avi Kivity , kvm , Alexander Graf To: Christoph Hellwig Return-path: Received: from david.siemens.de ([192.35.17.14]:20448 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750922Ab1ECPdL (ORCPT ); Tue, 3 May 2011 11:33:11 -0400 In-Reply-To: <20110503151234.GA13171@lst.de> Sender: kvm-owner@vger.kernel.org List-ID: On 2011-05-03 17:12, Christoph Hellwig wrote: > On Tue, May 03, 2011 at 04:05:37PM +0200, Jan Kiszka wrote: >> This helps reducing our build-time checks for feature support in the >> available Linux kernel headers. And it helps users that do not have >> sufficiently recent headers installed on their build machine. >> >> Header upstate is triggered via 'make update-linux-headers', optionally >> specifying a kernel directory as source via 'LINUX='. > > Why not make it a shell scripts? It's not like it's part of the build > system. I also think the source tree argument should be mandatory instead > of grabbing random headers. Yes, makes sense. I just adopted the kvm-kmod style here which I'm used to. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49901) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHHaz-0002xq-Tu for qemu-devel@nongnu.org; Tue, 03 May 2011 11:33:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QHHay-0000oA-3T for qemu-devel@nongnu.org; Tue, 03 May 2011 11:33:05 -0400 Received: from david.siemens.de ([192.35.17.14]:17897) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHHax-0000ne-PX for qemu-devel@nongnu.org; Tue, 03 May 2011 11:33:04 -0400 Message-ID: <4DC0202B.5020407@siemens.com> Date: Tue, 03 May 2011 17:32:59 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4DC00BB1.7000008@siemens.com> <20110503151234.GA13171@lst.de> In-Reply-To: <20110503151234.GA13171@lst.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC][PATCH] Import Linux headers for KVM and vhost List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: Anthony Liguori , kvm , Marcelo Tosatti , Alexander Graf , qemu-devel , Avi Kivity On 2011-05-03 17:12, Christoph Hellwig wrote: > On Tue, May 03, 2011 at 04:05:37PM +0200, Jan Kiszka wrote: >> This helps reducing our build-time checks for feature support in the >> available Linux kernel headers. And it helps users that do not have >> sufficiently recent headers installed on their build machine. >> >> Header upstate is triggered via 'make update-linux-headers', optionally >> specifying a kernel directory as source via 'LINUX='. > > Why not make it a shell scripts? It's not like it's part of the build > system. I also think the source tree argument should be mandatory instead > of grabbing random headers. Yes, makes sense. I just adopted the kvm-kmod style here which I'm used to. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux