From: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
To: dietmar.schindler@domain.hid
Cc: xenomai@xenomai.org
Subject: Re: [Xenomai-help] message pipe message boundaries
Date: Wed, 04 May 2011 08:40:32 +0200 [thread overview]
Message-ID: <4DC0F4E0.2070707@domain.hid> (raw)
In-Reply-To: <1183078C0D064042B3AD2D03E3859EF174E92F@AREXCH02.mra.roland-man.biz>
On 05/04/2011 08:36 AM, dietmar.schindler@domain.hid wrote:
>> From: Gilles Chanteperdrix [mailto:gilles.chanteperdrix@xenomai.org]
>> Sent: Tuesday, May 03, 2011 7:36 PM
>> ...
>>>> On 05/03/2011 10:15 AM, dietmar.schindler@domain.hid wrote:
>>>>> ...
>>>>> We at manroland now use (with Xenomai 2.4) the attached patch, which
>>>>> implements the readv file operation in the rtpipe driver so that the
>>>>> assertion "One read() per rt_pipe_write()" (message boundaries
>>>>> preserved) covers readv(2) also.
>> ...
>> Unfortunately, the patch as is is a bit hard to read. IMO, only
>> implementing readv will result in a more straight-forward implementation
>> which we could merge.
>
> I understand. If you prefer, I can provide a patch which multiplies out the functions to a separate readv, though this will result in code duplication of the whole read function. Alternatively, I could comment the changes so that they are easier to read.
> Please let me know which flavour you favour.
What I suggest, is that you make a patch which removes the read
implementation and adds the readv implementation. In this case, the
kernel will use readv to implement read anyway, and there will be no
code duplication.
--
Gilles.
next prev parent reply other threads:[~2011-05-04 6:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-26 9:48 [Xenomai-help] message pipe message boundaries dietmar.schindler
2011-04-26 20:27 ` Philippe Gerum
2011-04-27 8:50 ` dietmar.schindler
2011-04-27 12:22 ` dietmar.schindler
2011-04-27 21:42 ` Philippe Gerum
2011-04-29 6:30 ` dietmar.schindler
2011-05-03 8:15 ` dietmar.schindler
2011-05-03 11:00 ` Gilles Chanteperdrix
2011-05-03 11:27 ` dietmar.schindler
2011-05-03 17:35 ` Gilles Chanteperdrix
2011-05-04 6:36 ` dietmar.schindler
2011-05-04 6:40 ` Gilles Chanteperdrix [this message]
2011-05-04 14:34 ` dietmar.schindler
2011-05-05 8:14 ` Gilles Chanteperdrix
2011-05-09 7:36 ` dietmar.schindler
2011-05-11 9:12 ` Gilles Chanteperdrix
2011-05-11 9:20 ` Philippe Gerum
2011-05-11 10:48 ` dietmar.schindler
2011-05-11 10:55 ` Gilles Chanteperdrix
2011-05-11 11:02 ` Philippe Gerum
2011-05-19 13:09 ` dietmar.schindler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC0F4E0.2070707@domain.hid \
--to=gilles.chanteperdrix@xenomai.org \
--cc=dietmar.schindler@domain.hid \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.