From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============1321647391818150517==" MIME-Version: 1.0 From: Guillaume Zajac Subject: Re: [PATCH v3 09/26] gathdlc: add g_at_hdlc_suspend() definition Date: Wed, 04 May 2011 11:23:05 +0200 Message-ID: <4DC11AF9.5070804@linux.intel.com> In-Reply-To: <4DBEA27F.4080009@gmail.com> List-Id: To: ofono@ofono.org --===============1321647391818150517== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Denis, On 02/05/2011 14:24, Denis Kenzior wrote: > Hi Guillaume, > > On 04/01/2011 03:56 AM, Guillaume Zajac wrote: >> --- >> gatchat/gathdlc.c | 9 +++++++++ >> 1 files changed, 9 insertions(+), 0 deletions(-) >> >> diff --git a/gatchat/gathdlc.c b/gatchat/gathdlc.c >> index db4ad5a..37f2539 100644 >> --- a/gatchat/gathdlc.c >> +++ b/gatchat/gathdlc.c >> @@ -595,3 +595,12 @@ void g_at_hdlc_set_no_carrier_detect(GAtHDLC *hdlc,= gboolean detect) >> >> hdlc->no_carrier_detect =3D detect; >> } >> + >> +void g_at_hdlc_suspend(GAtHDLC *hdlc) >> +{ >> + if (hdlc =3D=3D NULL) >> + return; >> + >> + g_at_io_set_write_handler(hdlc->io, NULL, NULL); >> + g_at_io_set_read_handler(hdlc->io, NULL, NULL); >> +} > What do you think of simply putting this into the function that calls > the HDLC suspend callback? > Yes it would avoid some round-trips. However we might need this function for gsmdial to make some tests. Kind regards, Guillaume --===============1321647391818150517==--