From: Dimitris Michailidis <dm@chelsio.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Alexander Duyck <alexander.h.duyck@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [ethtool PATCH 4/4] v5 Add RX packet classification interface
Date: Wed, 04 May 2011 12:06:12 -0700 [thread overview]
Message-ID: <4DC1A3A4.20900@chelsio.com> (raw)
In-Reply-To: <1304532342.2926.46.camel@bwh-desktop>
On 05/04/2011 11:05 AM, Ben Hutchings wrote:
> How about having ETHTOOL_GRXCLSRLCNT set a flag in the 'data' field to
> indicate that the driver can assign locations? (We would have to
> specify that for compatibility with older kernels the application must
> initialise this filed to 0.)
>
> rmgr_init() would then check for this flag.
I think this is a good suggestion if we want to support location selection by
either the driver or ethtool. I also think ethtool's assumption that it is the
only allocator and can allocate race-free is fundamentally flawed (take two
parallel ethtools).
next prev parent reply other threads:[~2011-05-04 19:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 16:12 [ethtool PATCH 0/4] Add support for network flow classifier Alexander Duyck
2011-05-03 16:12 ` [ethtool PATCH 1/4] ethtool: remove strings based approach for displaying n-tuple Alexander Duyck
2011-05-03 16:12 ` [ethtool PATCH 2/4] Cleanup defines and header includes to address several issues Alexander Duyck
2011-05-03 16:12 ` [ethtool PATCH 3/4] Add support for __be64 and bitops, centralize several needed macros Alexander Duyck
2011-05-03 16:12 ` [ethtool PATCH 4/4] v5 Add RX packet classification interface Alexander Duyck
2011-05-03 23:23 ` Dimitris Michailidis
2011-05-03 23:34 ` Ben Hutchings
2011-05-04 0:29 ` Alexander Duyck
2011-05-04 1:35 ` Dimitris Michailidis
2011-05-04 3:10 ` Alexander Duyck
2011-05-04 17:09 ` Dimitris Michailidis
2011-05-04 17:24 ` Ben Hutchings
2011-05-04 17:33 ` Dimitris Michailidis
2011-05-04 17:41 ` Alexander Duyck
2011-05-04 18:05 ` Ben Hutchings
2011-05-04 18:21 ` Alexander Duyck
2011-05-04 18:45 ` Ben Hutchings
2011-05-04 21:07 ` Alexander Duyck
2011-05-04 21:54 ` Ben Hutchings
2011-05-04 19:06 ` Dimitris Michailidis [this message]
2011-05-04 18:18 ` Dimitris Michailidis
2011-05-04 18:35 ` Alexander Duyck
2011-05-04 18:50 ` Dimitris Michailidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC1A3A4.20900@chelsio.com \
--to=dm@chelsio.com \
--cc=alexander.h.duyck@intel.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.