All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Johannes Berg <johannes@sipsolutions.net>,
	John Linville <linville@tuxdriver.com>
Cc: wireless <linux-wireless@vger.kernel.org>
Subject: WARNING from mac80211
Date: Wed, 04 May 2011 14:55:53 -0500	[thread overview]
Message-ID: <4DC1AF49.7080204@lwfinger.net> (raw)

Johannes and John,

A regression in recent versions of mac80211 are generating the WARNING at 
net/mac80211/wep.c:101, because the skb headroom is less than WEP_IV_LEN or the 
tailroom is less than WEP_ICV_LEN. My testing indicates that it is a headroom 
problem as the following hack "fixes" it:

Index: wireless-testing-new/net/mac80211/tx.c
===================================================================
--- wireless-testing-new.orig/net/mac80211/tx.c
+++ wireless-testing-new/net/mac80211/tx.c
@@ -1935,6 +1935,8 @@ netdev_tx_t ieee80211_subif_start_xmit(s
                 head_need += IEEE80211_ENCRYPT_HEADROOM;
                 head_need += local->tx_headroom;
                 head_need = max_t(int, 0, head_need);
+               if (head_need < WEP_IV_LEN)
+                       head_need = WEP_IV_LEN;
                 if (ieee80211_skb_resize(local, skb, head_need, true))
                         goto fail;
         }

I'm certain that this is too simple minded, but it at least points to a place to 
look. I have not bisected the problem to see which commit caused the regression, 
but I can if you want.

Larry

             reply	other threads:[~2011-05-04 19:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-04 19:55 Larry Finger [this message]
2011-05-04 20:02 ` WARNING from mac80211 Johannes Berg
2011-05-04 20:11   ` Larry Finger
2011-05-04 20:15     ` Johannes Berg
2011-05-05  4:47     ` Mohammed Shafi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DC1AF49.7080204@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.