From: Sunil Mushran <sunil.mushran@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] freeing memory allocated in security_inode_init_security()
Date: Wed, 04 May 2011 13:09:39 -0700 [thread overview]
Message-ID: <4DC1B283.8080105@oracle.com> (raw)
In-Reply-To: <1304536698.3227.36.camel@localhost.localdomain>
On 05/04/2011 12:18 PM, Mimi Zohar wrote:
> Although it isn't documented in security.c, the LSM
> security_inode_init_security() hook allocates memory for xattr name and
> value, expecting the caller to release the memory afterwards.
>
> I'm making my way through the different filesystems adding a subsequent
> call to evm_inode_post_init_security(). I see the call to
> ocfs2_init_security_and_acl() calls ocfs2_init_security_get(), which in
> turn calls security_inode_init_security(), but am having a hard time
> finding where the name and value are subsequently freed. Would
> appreciate if someone could point it out.
I think we have a leak in the reflink code path. mknod and symlink
code paths free the name/value pair.
Tiger, Please could you post a fix.
next prev parent reply other threads:[~2011-05-04 20:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 19:18 [Ocfs2-devel] freeing memory allocated in security_inode_init_security() Mimi Zohar
2011-05-04 20:09 ` Sunil Mushran [this message]
2011-05-30 6:41 ` Tiger Yang
2011-05-04 20:57 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC1B283.8080105@oracle.com \
--to=sunil.mushran@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.