All of lore.kernel.org
 help / color / mirror / Atom feed
From: ryan@bluewatersys.com (Ryan Mallon)
To: linux-arm-kernel@lists.infradead.org
Subject: AT91: Interrupt handling independent of processor base-address
Date: Thu, 05 May 2011 08:56:06 +1200	[thread overview]
Message-ID: <4DC1BD66.5060905@bluewatersys.com> (raw)
In-Reply-To: <4DC1B9A3.7050107@bluewatersys.com>

On 05/05/2011 08:40 AM, Ryan Mallon wrote:
> On 05/02/2011 11:04 AM, Andrew Victor wrote:
>> For supporting multiple AT91 processors in a single kernel image, the
>> base address of the AIC controller needs to be calculated in the
>> processor initialization code and then provided to the AIC driver.
>>  * Low-level IRQ hander in entry-macro.S also updated.
>>  * AT91_AIC definitions renamed to AT91xxx_AIC.
>>
>> All these patches are here:
>>  git://github.com/at91linux/linux-2.6-at91.git/av-devel
>>
>> Signed-off-by: Andrew Victor <linux@maxim.org.za>

<snip>

>> diff --git a/arch/arm/mach-at91/irq.c b/arch/arm/mach-at91/irq.c
>> index aff808b..8b04b3c 100644
>> --- a/arch/arm/mach-at91/irq.c
>> +++ b/arch/arm/mach-at91/irq.c
>> @@ -33,23 +33,26 @@
>>  #include <asm/mach/irq.h>
>>  #include <asm/mach/map.h>
>>  
>> +/* Base IO address of AIC */
>> +void __iomem *at91_aic_base_addr __read_mostly;
>> +
> 
> Since we eventually will have a number of these base addresses as
> variables is it worth consolidating them into a single struct, i.e:
> 
> struct at91_sys {
> 	void __iomem *aic;
> 	void __iomem *dbgu;
> 	void __iomem *pioa;
> 	...
> };
> 
> struct at91_sys at91_sys __read_mostly;

Ignore this. Looking at the other patches you have posted its not a
viable idea.

~Ryan

-- 
Bluewater Systems Ltd - ARM Technology Solution Centre

Ryan Mallon         		5 Amuri Park, 404 Barbadoes St
ryan at bluewatersys.com         	PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com	New Zealand
Phone: +64 3 3779127		Freecall: Australia 1800 148 751
Fax:   +64 3 3779135			  USA 1800 261 2934

      reply	other threads:[~2011-05-04 20:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-01 23:04 AT91: Interrupt handling independent of processor base-address Andrew Victor
2011-05-04  6:52 ` Jean-Christophe PLAGNIOL-VILLARD
2011-05-04 20:40 ` Ryan Mallon
2011-05-04 20:56   ` Ryan Mallon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DC1BD66.5060905@bluewatersys.com \
    --to=ryan@bluewatersys.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.