From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Romanick Subject: Re: [PATCH] glxproto: make GLX swap event struct match spec Date: Wed, 04 May 2011 15:11:16 -0700 Message-ID: <4DC1CF04.2060708@freedesktop.org> References: <1304450489-31415-1-git-send-email-jbarnes@virtuousgeek.org> <1304450489-31415-2-git-send-email-jbarnes@virtuousgeek.org> <20110503140231.704a1b5c@jbarnes-desktop> <20110503140858.65d5f945@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110503140858.65d5f945@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: xorg-devel-bounces+gcfxd-xorg-devel=m.gmane.org-go0+a7rfsptAfugRpC6u6w@public.gmane.org Errors-To: xorg-devel-bounces+gcfxd-xorg-devel=m.gmane.org-go0+a7rfsptAfugRpC6u6w@public.gmane.org To: Jesse Barnes Cc: xorg-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, mesa-dev-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: dri-devel@lists.freedesktop.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 05/03/2011 02:08 PM, Jesse Barnes wrote: > On Tue, 3 May 2011 14:02:31 -0700 > Jesse Barnes wrote: > >> On Tue, 03 May 2011 13:54:38 -0700 >> Keith Packard wrote: >> >>> On Tue, 3 May 2011 12:21:24 -0700, Jesse Barnes wrote: >>> >>>> We only spec a 32 bit swap count, so drop the high sbc field. >>> >>> You're missing the explicit 16-bit padding field after 'event_type' >>> >>> The documented encoding >>> http://www.opengl.org/registry/specs/INTEL/swap_event.txt needs to be >>> fixed to match this, it has the padding at the end which leaves most of >>> the structure mis-aligned. >> >> Right, another case where we updated the spec incorrectly then failed >> to make the code match the broken definition (the complete enums also >> need to match the final values, which are correct in the first part of >> the spec). Yay for divergence. > > Fixed version below. > Does this need the "B16" cruft? -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAk3BzwQACgkQX1gOwKyEAw/SowCfaAm1gxkowryhD2ku9oPMlaUY YyoAniZgXMFszpUBwnJH17JDyZwtsOw+ =k7tr -----END PGP SIGNATURE----- _______________________________________________ xorg-devel-go0+a7rfsptAfugRpC6u6w@public.gmane.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel