From: Jeff Garzik <jgarzik@pobox.com>
To: shaohua.li@intel.com
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
jaxboe@fusionio.com, htejun@gmail.com, hch@infradead.org,
djwong@us.ibm.com, sshtylyov@mvista.com
Subject: Re: [patch v3 1/3] block: add a non-queueable flush flag
Date: Wed, 04 May 2011 22:17:39 -0400 [thread overview]
Message-ID: <4DC208C3.7070902@pobox.com> (raw)
In-Reply-To: <20110505020417.586891398@sli10-conroe.sh.intel.com>
On 05/04/2011 09:59 PM, shaohua.li@intel.com wrote:
> flush request isn't queueable in some drives. Add a flag to let driver
> notify block layer about this. We can optimize flush performance with the
> knowledge.
>
> Signed-off-by: Shaohua Li<shaohua.li@intel.com>
> ---
> block/blk-settings.c | 6 ++++++
> include/linux/blkdev.h | 7 +++++++
> 2 files changed, 13 insertions(+)
hmmm.
This assumes that flush on new hardware, by default, is queueable.
I think the sense should be reversed: don't enable the optimization,
unless we know the optimization works.
That seems safer than always enabling the optimization, unless we know
it does not work. That is not a fail-safe mode of operation.
Jeff
next prev parent reply other threads:[~2011-05-05 2:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 1:59 [patch v3 0/3] block: optimize flush for non-queueable flush drive shaohua.li
2011-05-05 1:59 ` [patch v3 1/3] block: add a non-queueable flush flag shaohua.li
2011-05-05 2:17 ` Jeff Garzik [this message]
2011-05-05 2:21 ` Shaohua Li
2011-05-05 7:53 ` Tejun Heo
2011-05-05 1:59 ` [patch v3 2/3] block: hold queue if flush is running for non-queueable flush drive shaohua.li
2011-05-05 8:38 ` Tejun Heo
2011-05-06 4:32 ` Shaohua Li
2011-05-06 6:53 ` Tejun Heo
2011-05-06 17:28 ` Jens Axboe
2011-05-09 13:03 ` Vivek Goyal
2011-05-09 13:50 ` Shaohua Li
2011-05-09 13:58 ` Vivek Goyal
2011-05-09 14:37 ` Tejun Heo
2011-05-05 1:59 ` [patch v3 3/3] SATA: enable non-queueable flush flag shaohua.li
2011-05-05 7:54 ` Tejun Heo
2011-05-05 12:33 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC208C3.7070902@pobox.com \
--to=jgarzik@pobox.com \
--cc=djwong@us.ibm.com \
--cc=hch@infradead.org \
--cc=htejun@gmail.com \
--cc=jaxboe@fusionio.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.